Uh oh!
There was an error while loading. Please reload this page.
[SPARK-41468][SQL][FOLLOWUP] Handle NamedLambdaVariables in EquivalentExpressions - #39046
Closed
peter-toth wants to merge 1 commit into
Closed
Conversation
peter-toth
commented
Dec 13, 2022
ContributorAuthor
cc @cloud-fan |
cloud-fan
approved these changes
Dec 13, 2022
cloud-fan
commented
Dec 13, 2022
Contributor
thanks, merging to master! |
beliefer pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…tExpressions ### What changes were proposed in this pull request? This is a follow-up PR to apache#39010 to handle `NamedLambdaVariable`s too. ### Why are the changes needed? To avoid possible issues with higer-order functions. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs. Closesapache#39046 from peter-toth/SPARK-41468-fix-planexpressions-in-equivalentexpressions-follow-up. Authored-by: Peter Toth <peter.toth@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
HyukjinKwon pushed a commit
that referenced
this pull request
Mar 20, 2023
…uivalentExpressions ### What changes were proposed in this pull request? This PR reverts the follow-up PR of SPARK-41468: #39046 ### Why are the changes needed? These changes are not needed and actually might cause performance regression due to preventing higher order function subexpression elimination in `EquivalentExpressions`. Please find related conversation here: #40473 (comment) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs. Closes#40475 from peter-toth/SPARK-42852-revert-namedlambdavariable-changes. Authored-by: Peter Toth <peter.toth@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon pushed a commit
that referenced
this pull request
Mar 20, 2023
…uivalentExpressions ### What changes were proposed in this pull request? This PR reverts the follow-up PR of SPARK-41468: #39046 ### Why are the changes needed? These changes are not needed and actually might cause performance regression due to preventing higher order function subexpression elimination in `EquivalentExpressions`. Please find related conversation here: #40473 (comment) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs. Closes#40475 from peter-toth/SPARK-42852-revert-namedlambdavariable-changes. Authored-by: Peter Toth <peter.toth@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit ce3b03d) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…uivalentExpressions ### What changes were proposed in this pull request? This PR reverts the follow-up PR of SPARK-41468: apache#39046 ### Why are the changes needed? These changes are not needed and actually might cause performance regression due to preventing higher order function subexpression elimination in `EquivalentExpressions`. Please find related conversation here: apache#40473 (comment) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs. Closesapache#40475 from peter-toth/SPARK-42852-revert-namedlambdavariable-changes. Authored-by: Peter Toth <peter.toth@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit ce3b03d) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up PR to #39010 to handle
NamedLambdaVariables too.Why are the changes needed?
To avoid possible issues with higer-order functions.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.