Skip to content

[SPARK-4861][SQL] Refactory command in spark sql - #3948

Closed
scwf wants to merge 3 commits into
apache:masterfrom
scwf:followup-SPARK-4861
Closed

[SPARK-4861][SQL] Refactory command in spark sql#3948
scwf wants to merge 3 commits into
apache:masterfrom
scwf:followup-SPARK-4861

Conversation

@scwf

@scwfscwf commented Jan 8, 2015

Copy link
Copy Markdown
Contributor

Follow up for #3712.
This PR finally remove CommandStrategy and make all commands follow RunnableCommand so they can go with case r: RunnableCommand => ExecutedCommand(r) :: Nil.

One exception is the DescribeCommand of hive, which is a special case and need to distinguish hive table and temporary table, so still keep HiveCommandStrategy here.

@SparkQA

Copy link
Copy Markdown

Test build #25217 has started for PR 3948 at commit 6677766.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

Test build #25217 has finished for PR 3948 at commit 6677766.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25217/
Test FAILed.

@scwf
scwfforce-pushed the followup-SPARK-4861 branch from 6677766 to 2c62e9dCompareJanuary 8, 2015 09:39
@SparkQA

Copy link
Copy Markdown

Test build #25218 has started for PR 3948 at commit 2c62e9d.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

Test build #25220 has started for PR 3948 at commit 6b48e64.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

Test build #25218 has finished for PR 3948 at commit 2c62e9d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25218/
Test PASSed.

@SparkQA

Copy link
Copy Markdown

Test build #25220 has finished for PR 3948 at commit 6b48e64.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25220/
Test PASSed.

@scwf

scwf commented Jan 8, 2015

Copy link
Copy Markdown
ContributorAuthor

/cc @marmbrus

@marmbrus

Copy link
Copy Markdown
Contributor

Thanks, merging to master.

@scwf
scwf deleted the followup-SPARK-4861 branch January 10, 2015 23:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@scwf@SparkQA@AmplabJenkins@marmbrus