Uh oh!
There was an error while loading. Please reload this page.
support leftsemijoin for sparkSQL - #395
Closed
adrian-wang wants to merge 2 commits into
Closed
Conversation
AmplabJenkins
commented
Apr 11, 2014
Can one of the admins verify this patch? |
marmbrus
commented
Apr 14, 2014
Contributor
ok to test |
chenghao-intel
commented
Apr 15, 2014
Contributor
Besides the BroadcastNestedLoopJoin, I think the left semi join may also need to be implemented in the HashJoin. |
marmbrus
commented
Apr 15, 2014
Contributor
Thanks for adding this! It would be great if you could create a JIRA for tracking this new feature. Also, right now HashJoin is only used for Inner joins, though it would be good to also extend that at some point (though maybe not in this PR). One design question is which of the following is better:
I need to look at this code closer, but will not have time to do that until after we start cutting release candidates for 1.0. |
adrian-wang
commented
Apr 15, 2014
ContributorAuthor
I'll create a JIRA soon. |
adrian-wang
commented
Apr 15, 2014
ContributorAuthor
Thanks for your comments! Here's SPARK-1495[https://issues.apache.org/jira/browse/SPARK-1495]. |
Contributor
There was a problem hiding this comment.
There is no need to call buildRow here, as you can just use streamedRow.
marmbrus
commented
May 8, 2014
Contributor
Just checking in to see if there is anything I can help with here. Would be cool to have this feature! |
adrian-wang
commented
May 9, 2014
ContributorAuthor
Busy with some other issues recently, I'll try fix it this weekend. |
adrian-wang
commented
May 12, 2014
ContributorAuthor
I'll switch to a newer branch with #418 to split leftsemi from other joins. |
pwendell added a commit
to pwendell/spark
that referenced
this pull request
May 12, 2014
…urn_scala Remove simple redundant return statements for Scala methods/functions Remove simple redundant return statements for Scala methods/functions: -) Only change simple return statements at the end of method -) Ignore the complex if-else check -) Ignore the ones inside synchronized -) Add small changes to making var to val if possible and remove () for simple get This hopefully makes the review simpler =) Pass compile and tests.
adrian-wang
commented
May 21, 2014
ContributorAuthor
Just mention it here, I have submitted another solution as #837 |
marmbrus
commented
Jun 2, 2014
Contributor
Mind closing this version if it is subsumed by #837 ? Thanks! |
adrian-wang
commented
Jun 2, 2014
ContributorAuthor
Thanks, I have closed this. |
asfgit pushed a commit
that referenced
this pull request
Jun 9, 2014
Just submit another solution for #395 Author: Daoyuan <daoyuan.wang@intel.com> Author: Michael Armbrust <michael@databricks.com> Author: Daoyuan Wang <daoyuan.wang@intel.com> Closes#837 from adrian-wang/left-semi-join-support and squashes the following commits: d39cd12 [Daoyuan Wang] Merge pull request #1 from marmbrus/pr/837 6713c09 [Michael Armbrust] Better debugging for failed query tests. 035b73e [Michael Armbrust] Add test for left semi that can't be done with a hash join. 5ec6fa4 [Michael Armbrust] Add left semi to SQL Parser. 4c726e5 [Daoyuan] improvement according to Michael 8d4a121 [Daoyuan] add golden files for leftsemijoin 83a3c8a [Daoyuan] scala style fix 14cff80 [Daoyuan] add support for left semi join (cherry picked from commit 0cf6002) Signed-off-by: Michael Armbrust <michael@databricks.com>
asfgit pushed a commit
that referenced
this pull request
Jun 9, 2014
Just submit another solution for #395 Author: Daoyuan <daoyuan.wang@intel.com> Author: Michael Armbrust <michael@databricks.com> Author: Daoyuan Wang <daoyuan.wang@intel.com> Closes#837 from adrian-wang/left-semi-join-support and squashes the following commits: d39cd12 [Daoyuan Wang] Merge pull request #1 from marmbrus/pr/837 6713c09 [Michael Armbrust] Better debugging for failed query tests. 035b73e [Michael Armbrust] Add test for left semi that can't be done with a hash join. 5ec6fa4 [Michael Armbrust] Add left semi to SQL Parser. 4c726e5 [Daoyuan] improvement according to Michael 8d4a121 [Daoyuan] add golden files for leftsemijoin 83a3c8a [Daoyuan] scala style fix 14cff80 [Daoyuan] add support for left semi join
pdeyhim pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
Just submit another solution for apache#395 Author: Daoyuan <daoyuan.wang@intel.com> Author: Michael Armbrust <michael@databricks.com> Author: Daoyuan Wang <daoyuan.wang@intel.com> Closesapache#837 from adrian-wang/left-semi-join-support and squashes the following commits: d39cd12 [Daoyuan Wang] Merge pull request apache#1 from marmbrus/pr/837 6713c09 [Michael Armbrust] Better debugging for failed query tests. 035b73e [Michael Armbrust] Add test for left semi that can't be done with a hash join. 5ec6fa4 [Michael Armbrust] Add left semi to SQL Parser. 4c726e5 [Daoyuan] improvement according to Michael 8d4a121 [Daoyuan] add golden files for leftsemijoin 83a3c8a [Daoyuan] scala style fix 14cff80 [Daoyuan] add support for left semi join
xiliu82 pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Just submit another solution for apache#395 Author: Daoyuan <daoyuan.wang@intel.com> Author: Michael Armbrust <michael@databricks.com> Author: Daoyuan Wang <daoyuan.wang@intel.com> Closesapache#837 from adrian-wang/left-semi-join-support and squashes the following commits: d39cd12 [Daoyuan Wang] Merge pull request apache#1 from marmbrus/pr/837 6713c09 [Michael Armbrust] Better debugging for failed query tests. 035b73e [Michael Armbrust] Add test for left semi that can't be done with a hash join. 5ec6fa4 [Michael Armbrust] Add left semi to SQL Parser. 4c726e5 [Daoyuan] improvement according to Michael 8d4a121 [Daoyuan] add golden files for leftsemijoin 83a3c8a [Daoyuan] scala style fix 14cff80 [Daoyuan] add support for left semi join
mccheah pushed a commit
to mccheah/spark
that referenced
this pull request
Nov 28, 2018
bzhaoopenstack pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
Enable AKSK test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.