Uh oh!
There was an error while loading. Please reload this page.
[SPARK-40599][SQL] Relax multiTransform rule type to allow alternatives to be any kinds of Seq - #39652
Closed
peter-toth wants to merge 1 commit into
Closed
Conversation
…ateCartesianProduct` helper public
peter-toth
commented
Jan 19, 2023
ContributorAuthor
@cloud-fan, could you please take a look at this small improvement? |
cloud-fan
approved these changes
Jan 19, 2023
cloud-fan
commented
Jan 19, 2023
Contributor
thanks, merging to master! |
peter-toth
commented
Jan 19, 2023
ContributorAuthor
Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up PR to #38034. It relaxes
multiTransformDown()'sruleparameter type to accept any kinds ofSeqand makeMultiTransform.generateCartesianProduct()helper public.Why are the changes needed?
API mprovement.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.