Skip to content

[SPARK-41413][FOLLOWUP][SQL][TESTS] More test coverage in KeyGroupedPartitioningSuite - #39708

Closed
sunchao wants to merge 1 commit into
apache:masterfrom
sunchao:SPARK-41413-follow-up
Closed

[SPARK-41413][FOLLOWUP][SQL][TESTS] More test coverage in KeyGroupedPartitioningSuite#39708
sunchao wants to merge 1 commit into
apache:masterfrom
sunchao:SPARK-41413-follow-up

Conversation

@sunchao

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This is a follow-up of #38950, to make sure we run all tests in the suite with spark.sql.sources.v2.bucketing.pushPartValues.enabled on and off.

Why are the changes needed?

To increase test coverage. As the config spark.sql.sources.v2.bucketing.pushPartValues.enabled changes, the test results would change accordingly, so we should make sure the suite covers both cases.

Does this PR introduce any user-facing change?

No, this is just test related change.

How was this patch tested?

N/A

@sunchao
sunchao marked this pull request as ready for review January 23, 2023 18:43
@sunchao

Copy link
Copy Markdown
MemberAuthor

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs)

@dongjoon-hyundongjoon-hyun changed the title [SPARK-41413][FOLLOWUP][SQL] More test coverage in KeyGroupedPartitioningSuite[SPARK-41413][FOLLOWUP][SQL][TESTS] More test coverage in KeyGroupedPartitioningSuiteJan 24, 2023
@dongjoon-hyun

Copy link
Copy Markdown
Member

Merged to master.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sunchao@dongjoon-hyun@viirya