Skip to content

[SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions - #4010

Closed
yhuai wants to merge 5 commits into
apache:masterfrom
yhuai:SPARK-4296-yin
Closed

[SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions#4010
yhuai wants to merge 5 commits into
apache:masterfrom
yhuai:SPARK-4296-yin

Conversation

@yhuai

Copy link
Copy Markdown
Contributor

I believe that SPARK-4296 has been fixed by 3684fd2. I am adding tests based #3910 (change the udf to HiveUDF instead).

@SparkQA

Copy link
Copy Markdown

Test build #25430 has started for PR 4010 at commit 6042328.

  • This patch merges cleanly.

@yhuaiyhuai changed the title [SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions[WIP][SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressionsJan 12, 2015
@yhuaiyhuai changed the title [WIP][SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions[SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressionsJan 12, 2015
@SparkQA

Copy link
Copy Markdown

Test build #25431 has started for PR 4010 at commit 6cfadd2.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

Test build #25430 has finished for PR 4010 at commit 6042328.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25430/
Test FAILed.

@SparkQA

Copy link
Copy Markdown

Test build #25431 has finished for PR 4010 at commit 6cfadd2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25431/
Test PASSed.

@liancheng

Copy link
Copy Markdown
Contributor

LGTM, thanks for pointing out 3684fd2 fixes this!

Conflicts:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
@SparkQA

Copy link
Copy Markdown

Test build #25874 has started for PR 4010 at commit 6343800.

  • This patch merges cleanly.

@SparkQA

Copy link
Copy Markdown

Test build #25874 has finished for PR 4010 at commit 6343800.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25874/
Test PASSed.

@marmbrus

Copy link
Copy Markdown
Contributor

Thanks! Merged to master.

@yhuai
yhuai deleted the SPARK-4296-yin branch February 11, 2015 18:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@yhuai@SparkQA@AmplabJenkins@liancheng@marmbrus