[SPARK-5239][CORE]JdbcRDD throws "java.lang.AbstractMethodError: oracle.jdbc.driver.xxxxxx.isClosed()Z"

[luogankun]

rs.isClosed() will throws:

Exception in thread "main" java.lang.AbstractMethodError: oracle.jdbc.driver.OracleResultSetImpl.isClosed()Z

Similarly,stmt.isClosed() will throws

Exception in thread "main" java.lang.AbstractMethodError: oracle.jdbc.driver.T4CPreparedStatement.isClosed()Z

Above exception is throwing because "isClosed()" is not implemented in the "OracleResultSetImpl" class which implements the ResultSet Interface in Ojdbc14.jar, I think use below condition to check whether resultset is null or not is enough

if (null != rs) { rs.close()
}

[AmplabJenkins]

Can one of the admins verify this patch?

[srowen]

See comment in JIRA; this should not be hacked around because the JDBC driver is unsuitable.

[srowen]

I take it back (see https://issues.apache.org/jira/browse/SPARK-5481) Yes, there's evidence of JDBC 3 drivers in the wild, still, and because I confirmed that close()ing these three objects is required to be a no-op if already closed, so, this really can't hurt.

Similar changes should be made in JDBCRDD.scala in Spark SQL. Could you update the PR to address that too?

[srowen]

@luogankun do you want to augment this PR to include JDBCRDD.scala too? I can do so if you're not available but wanted to give you the opportunity.

[srowen]

ok to test

[SparkQA]

Test build #27040 has started for PR 4033 at commit d8c61d6.

• This patch merges cleanly.

[SparkQA]

Test build #27040 has finished for PR 4033 at commit d8c61d6.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27040/
Test PASSed.

[luogankun]

Close the PR.

[srowen]

@luogankun are you going to make a new PR? or are you asking me to do so? you can just reopen and add to this PR.

[luogankun]

@srowen To do other things, forgot to resubmit a new PR after close the PR. Thanks for your help.

[srowen]

NP I will assign to you @luogankun in any event for the credit. Right now the new PR fails Hive tests, twice, which is suspicious, though I can't see how it would affect behavior. I'm waiting to see if it's just flakiness or a real problem.

[luogankun]

The stacktrace message of all failure testcase are: sbt.ForkMain$ForkError: Futures timed out after [1 minute], whether related Jenkins?