Uh oh!
There was an error while loading. Please reload this page.
[HOTFIX]: Minor clean up regarding skipped artifacts in build files. - #4080
[HOTFIX]: Minor clean up regarding skipped artifacts in build files.#4080pwendell wants to merge 1 commit into
Conversation
SparkQA
commented
Jan 16, 2015
Test build #25685 has started for PR 4080 at commit
|
pwendell
commented
Jan 16, 2015
SparkQA
commented
Jan 16, 2015
Test build #25685 has finished for PR 4080 at commit
|
AmplabJenkins
commented
Jan 16, 2015
Test FAILed. |
There are two relevant 'skip' configurations in the build, the first is for "mvn install" and the second is for "mvn deploy". As of 1.2, we actually use "mvn install" to generate our deployed artifcts, because we have some customization of the nexus upload due to having to cross compile for Scala 2.10 and 2.11. There is no reason to have differents settings for these values, this patch simply cleans this up for the repl/ and yarn/ projects.
pwendell
commented
Jan 16, 2015
@srowen my comment on the old one was that, since companies probably still use the traditional deploy pattern internally (e.g. they aren't doing anything fancy to cross build), I think it's fine to keep both settings throughout. |
pwendell
commented
Jan 16, 2015
Jenkins, test this please. |
srowen
commented
Jan 16, 2015
OK I think you're more aware of the usage. It should basically mirror the install config right? |
SparkQA
commented
Jan 16, 2015
Test build #25686 has started for PR 4080 at commit
|
vanzin
commented
Jan 16, 2015
Hi Patrick, This looks ok to me, but could you look at my comment in #4078? I'm not familiar with the Spark deploy scripts and I'm afraid I may have broken something there inadvertently. |
pwendell
commented
Jan 16, 2015
@vanzin yeah I think it was fine that you removed the install skop. We wanted to do that anyways because some people requested that we continue to publish those artifacts. This patch simply brings the deploy in sync with install. |
pwendell
commented
Jan 16, 2015
Jenkins, test this please. |
SparkQA
commented
Jan 16, 2015
Test build #25688 has started for PR 4080 at commit
|
SparkQA
commented
Jan 16, 2015
Test build #25686 has finished for PR 4080 at commit
|
AmplabJenkins
commented
Jan 16, 2015
Test PASSed. |
SparkQA
commented
Jan 17, 2015
Test build #25688 has finished for PR 4080 at commit
|
AmplabJenkins
commented
Jan 17, 2015
Test PASSed. |
There are two relevant 'skip' configurations in the build, the first
is for "mvn install" and the second is for "mvn deploy". As of 1.2,
we actually use "mvn install" to generate our deployed artifcts,
because we have some customization of the nexus upload due to having
to cross compile for Scala 2.10 and 2.11.
There is no reason to have differents settings for these values,
this patch simply cleans this up for the repl/ and yarn/
projects.