Skip to content

[SPARK-43266][SQL] Move MergeScalarSubqueries to spark-sql - #40932

Closed
peter-toth wants to merge 1 commit into
apache:masterfrom
peter-toth:SPARK-43266-move-mergescalarsubqueries-to-sql
Closed

[SPARK-43266][SQL] Move MergeScalarSubqueries to spark-sql#40932
peter-toth wants to merge 1 commit into
apache:masterfrom
peter-toth:SPARK-43266-move-mergescalarsubqueries-to-sql

Conversation

@peter-toth

@peter-tothpeter-toth commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR moves MergeScalarSubqueries from spark-catalyst to sparl-sql

Why are the changes needed?

Make SPARK-40193 / #37630 easier.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@peter-tothpeter-toth changed the title [SPARK-43266][SQL] Move MergeScalarSubqueries to spark-sql[SPARK-43266][SQL] Move MergeScalarSubqueries to sqlApr 24, 2023
@peter-tothpeter-toth changed the title [SPARK-43266][SQL] Move MergeScalarSubqueries to sql[SPARK-43266][SQL] Move MergeScalarSubqueries to spark-sqlApr 24, 2023
@peter-toth

Copy link
Copy Markdown
ContributorAuthor

cc @cloud-fan

@peter-toth
peter-tothforce-pushed the SPARK-43266-move-mergescalarsubqueries-to-sql branch from d50e115 to 37236f8CompareJuly 31, 2023 11:13

@belieferbeliefer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This change makes review easier.

@peter-toth

peter-toth commented Aug 22, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you. This change makes review easier.

No, this PR is not required any more.
Since I've updated #37630 and removed the physical plan comparison there is not need to move the MergeScalarSubqueries rule to spark-sql any more.
I'm gonna close this PR and please check the latest version of #37630. As there is no rule move in the latest version, github is able shows the actual diff better.

@beliefer

Copy link
Copy Markdown
Contributor

@peter-toth Got it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@peter-toth@beliefer