Uh oh!
There was an error while loading. Please reload this page.
[SPARK-43744][CONNECT][FOLLOW-UP]Throw error from the constructor - #42222
Closed
zhenlineo wants to merge 1 commit into
Closed
[SPARK-43744][CONNECT][FOLLOW-UP]Throw error from the constructor#42222zhenlineo wants to merge 1 commit into
zhenlineo wants to merge 1 commit into
Conversation
zhenlineo
marked this pull request as ready for review
July 29, 2023 18:22
HyukjinKwon
approved these changes
Jul 30, 2023
HyukjinKwon
commented
Jul 30, 2023
Member
Merged to master and branch-3.5. |
HyukjinKwon pushed a commit
that referenced
this pull request
Jul 30, 2023
### What changes were proposed in this pull request? Made the stub constructor to throw ClassNotFoundException if called. A tiny improvement to not recreate class loaders in executor if stubbing is not enabled. ### Why are the changes needed? Enhancement to #42069 Should be merged to 3.5. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests. Closes#42222 from zhenlineo/error-from-constuctor. Authored-by: Zhen Li <zhenlineo@users.noreply.github.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 5df1d79) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Made the stub constructor to throw ClassNotFoundException if called.
A tiny improvement to not recreate class loaders in executor if stubbing is not enabled.
Why are the changes needed?
Enhancement to #42069
Should be merged to 3.5.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests.