[SPARK-5135][SQL] Add support for describe table to DDL in SQLContext by OopsOutOfMemory · Pull Request #4227 · apache/spark

OopsOutOfMemory · 2015-01-27T19:09:09Z

Hi, @rxin @marmbrus
I considered your suggestion (in #4127) and now re-write it. This is now up-to-date.
Could u please review it ?

AmplabJenkins · 2015-01-27T19:12:10Z

Can one of the admins verify this patch?

rxin · 2015-01-28T02:16:20Z

Thanks for submitting the new version. Are these two PRs working on the same thing? #4207 Would be great if you two can chime in on each other's PR.

OopsOutOfMemory · 2015-01-28T02:32:40Z

yeah, @rxin, would you like to talk with @marmbrus for what we'd like to show in describe extended table in SQLContext and then file a JIRA issues? So that we can do it separately but not in this PR ?

rxin · 2015-02-04T05:17:23Z

@marmbrus this looks good to me. Any more comments?

@OopsOutOfMemory would be great to bring this up to date with master. Thanks.

OopsOutOfMemory · 2015-02-04T09:21:53Z

May AmplabJenkins test this please ?

rxin · 2015-02-04T09:26:46Z

Jenkins, test this please.

SparkQA · 2015-02-04T09:27:52Z

Test build #26743 has started for PR 4227 at commit a3061a5.

This patch merges cleanly.

SparkQA · 2015-02-04T10:41:26Z

Test build #26743 has finished for PR 4227 at commit a3061a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-04T10:41:29Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26743/
Test PASSed.

rxin · 2015-02-05T07:46:53Z

can you rename this simpleString?

rxin · 2015-02-05T07:50:03Z

I'd like to merge this into 1.3.0. Can you address the two comments I have and make sure it still works with other changes?

btw does this one conflict with your other change? https://github.com/apache/spark/pull/4249/files

OopsOutOfMemory · 2015-02-05T15:16:04Z

Hi, @rxin Thanks for the advice.
I refined the code according to your advice now I think it's ready to go.

yeah, this PR is a little conflict with https://github.com/apache/spark/pull/4249/files. They all modified logical DescribeCommand. But I think it's not a big deal. This two PRs (this and #4249). No matter which one will be merged first, I'll bring the other one up-to-date quickly. And I don't want to resolve the two issues in One PR which make issues untraceable.

rxin · 2015-02-05T19:47:26Z

Jenkins, retest this please.

SparkQA · 2015-02-05T19:52:34Z

Test build #26855 has started for PR 4227 at commit 053826f.

This patch merges cleanly.

SparkQA · 2015-02-05T21:04:24Z

Test build #26855 has finished for PR 4227 at commit 053826f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-05T21:04:28Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26855/
Test PASSed.

rxin · 2015-02-05T21:07:32Z

Thanks. Merging now.

Hi, rxin marmbrus I considered your suggestion (in #4127) and now re-write it. This is now up-to-date. Could u please review it ? Author: OopsOutOfMemory <victorshengli@126.com> Closes#4227 from OopsOutOfMemory/describe and squashes the following commits: 053826f [OopsOutOfMemory] describe (cherry picked from commit 4d8d070) Signed-off-by: Reynold Xin <rxin@databricks.com>

OopsOutOfMemory mentioned this pull request Jan 27, 2015
[SPARK-5135][SQL] Add support for describe [extended] table to DDL in SQLContext #4127
Closed

rxin mentioned this pull request Jan 28, 2015
[SQL] Implement Describe Table for SQLContext #4207
Closed

OopsOutOfMemory force-pushed the describe branch from 6b9c7b9 to a3061a5Compare February 4, 2015 09:21

rxin reviewed Feb 5, 2015
View reviewed changes

Comment threadsql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala Outdated
rxinFeb 5, 2015
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rename this simpleString?

describe
053826f

OopsOutOfMemory force-pushed the describe branch from 704a27b to 053826fCompare February 5, 2015 15:06

asfgit closed this in 4d8d070Feb 5, 2015

Uh oh!

Conversation

OopsOutOfMemory commented Jan 27, 2015

Uh oh!

AmplabJenkins commented Jan 27, 2015

Uh oh!

rxin commented Jan 28, 2015

Uh oh!

OopsOutOfMemory commented Jan 28, 2015

Uh oh!

rxin commented Feb 4, 2015

Uh oh!

OopsOutOfMemory commented Feb 4, 2015

Uh oh!

rxin commented Feb 4, 2015

Uh oh!

SparkQA commented Feb 4, 2015

Uh oh!

SparkQA commented Feb 4, 2015

Uh oh!

AmplabJenkins commented Feb 4, 2015

Uh oh!

rxinFeb 5, 2015

Choose a reason for hiding this comment

Uh oh!

rxin commented Feb 5, 2015

Uh oh!

OopsOutOfMemory commented Feb 5, 2015

Uh oh!

rxin commented Feb 5, 2015

Uh oh!

SparkQA commented Feb 5, 2015

Uh oh!

SparkQA commented Feb 5, 2015

Uh oh!

AmplabJenkins commented Feb 5, 2015

Uh oh!

rxin commented Feb 5, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants