Uh oh!
There was an error while loading. Please reload this page.
[SPARK-44778][SQL] Add the alias TIMEDIFF for TIMESTAMPDIFF - #42435
Closed
MaxGekk wants to merge 4 commits into
Closed
[SPARK-44778][SQL] Add the alias TIMEDIFF for TIMESTAMPDIFF#42435MaxGekk wants to merge 4 commits into
TIMEDIFF for TIMESTAMPDIFF#42435MaxGekk wants to merge 4 commits into
Conversation
TIMEDIFF for TIMESTAMPDIFFTIMEDIFF for TIMESTAMPDIFFTIMEDIFF for TIMESTAMPDIFFTIMEDIFF for TIMESTAMPDIFFMaxGekk
marked this pull request as ready for review
August 11, 2023 17:03
HyukjinKwon
approved these changes
Aug 11, 2023
MaxGekk
commented
Aug 12, 2023
MemberAuthor
Merging to master. Thank you, @HyukjinKwon for review. |
hvanhovell pushed a commit
to hvanhovell/spark
that referenced
this pull request
Aug 13, 2023
### What changes were proposed in this pull request? In the PR, I propose to extend the rules of `primaryExpression` in `SqlBaseParser.g4`, and one more function `TIMEDIFF` which accepts 3-args in the same way as the existing expressions `TIMESTAMPDIFF`. ### Why are the changes needed? To achieve feature parity w/ other system and make the migration to Spark SQL from such systems easier: 1. Snowflake: https://docs.snowflake.com/en/sql-reference/functions/timediff 2. MySQL/MariaDB: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_timediff ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the existing test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closesapache#42435 from MaxGekk/timediff. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
valentinp17 pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? In the PR, I propose to extend the rules of `primaryExpression` in `SqlBaseParser.g4`, and one more function `TIMEDIFF` which accepts 3-args in the same way as the existing expressions `TIMESTAMPDIFF`. ### Why are the changes needed? To achieve feature parity w/ other system and make the migration to Spark SQL from such systems easier: 1. Snowflake: https://docs.snowflake.com/en/sql-reference/functions/timediff 2. MySQL/MariaDB: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_timediff ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the existing test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closesapache#42435 from MaxGekk/timediff. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
sunchao pushed a commit
that referenced
this pull request
Mar 10, 2026
* [SPARK-44778][SQL] Add the alias `TIMEDIFF` for `TIMESTAMPDIFF` In the PR, I propose to extend the rules of `primaryExpression` in `SqlBaseParser.g4`, and one more function `TIMEDIFF` which accepts 3-args in the same way as the existing expressions `TIMESTAMPDIFF`. To achieve feature parity w/ other system and make the migration to Spark SQL from such systems easier: 1. Snowflake: https://docs.snowflake.com/en/sql-reference/functions/timediff 2. MySQL/MariaDB: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_timediff No. By running the existing test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes#42435 from MaxGekk/timediff. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> * changelog --------- Signed-off-by: Max Gekk <max.gekk@gmail.com> Co-authored-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to extend the rules of
primaryExpressioninSqlBaseParser.g4, and one more functionTIMEDIFFwhich accepts 3-args in the same way as the existing expressionsTIMESTAMPDIFF.Why are the changes needed?
To achieve feature parity w/ other system and make the migration to Spark SQL from such systems easier:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the existing test suites: