Uh oh!
There was an error while loading. Please reload this page.
[SPARK-44876][PYTHON] Fix Arrow-optimized Python UDF on Spark Connect - #42568
Closed
ueshin wants to merge 2 commits into
Closed
[SPARK-44876][PYTHON] Fix Arrow-optimized Python UDF on Spark Connect#42568ueshin wants to merge 2 commits into
ueshin wants to merge 2 commits into
Conversation
ueshin
commented
Aug 18, 2023
MemberAuthor
ueshin
commented
Aug 18, 2023
Uh oh!
There was an error while loading. Please reload this page.
xinrong-meng
approved these changes
Aug 18, 2023
Uh oh!
There was an error while loading. Please reload this page.
xinrong-meng
commented
Aug 18, 2023
Member
LGTM, pending test |
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
Sorry, but the PR title looks misleading to me. This PR technically implements UDF feature instead of simply enabling UDF test code. Can we have a more intuitive PR title?
dongjoon-hyun
commented
Aug 19, 2023
Member
To the reviewers,
I'm not disagree with backporting this PR, but I believe we need to give a correct PR title instead of saying a missing test coverage. |
MemberAuthor
@dongjoon-hyun Thanks for reviewing this! Sure, I'll update the title and description, but as for the backport, actually this is already implemented in 3.5 at #39384 and #40725. Unfortunately it had a bug and we didn't notice it because the test had not been activated for CI. |
HyukjinKwon
approved these changes
Aug 21, 2023
HyukjinKwon
commented
Aug 21, 2023
Member
Merged to master and branch-3.5 |
HyukjinKwon pushed a commit
that referenced
this pull request
Aug 21, 2023
### What changes were proposed in this pull request? Fixes Arrow-optimized Python UDF on Spark Connect. Also enables the missing test `pyspark.sql.tests.connect.test_parity_arrow_python_udf`. ### Why are the changes needed? `pyspark.sql.tests.connect.test_parity_arrow_python_udf` is not listed in `dev/sparktestsupport/modules.py`, and it fails when running manually. ``` ====================================================================== ERROR [0.072s]: test_register (pyspark.sql.tests.connect.test_parity_arrow_python_udf.ArrowPythonUDFParityTests) ---------------------------------------------------------------------- Traceback (most recent call last): ... pyspark.errors.exceptions.base.PySparkRuntimeError: [SCHEMA_MISMATCH_FOR_PANDAS_UDF] Result vector from pandas_udf was not the required length: expected 1, got 38. ``` The failure had not been captured because the test is missing in the `module.py` file. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes#42568 from ueshin/issues/SPARK-44876/test_parity_arrow_python_udf. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 75c0b8b) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
valentinp17 pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? Fixes Arrow-optimized Python UDF on Spark Connect. Also enables the missing test `pyspark.sql.tests.connect.test_parity_arrow_python_udf`. ### Why are the changes needed? `pyspark.sql.tests.connect.test_parity_arrow_python_udf` is not listed in `dev/sparktestsupport/modules.py`, and it fails when running manually. ``` ====================================================================== ERROR [0.072s]: test_register (pyspark.sql.tests.connect.test_parity_arrow_python_udf.ArrowPythonUDFParityTests) ---------------------------------------------------------------------- Traceback (most recent call last): ... pyspark.errors.exceptions.base.PySparkRuntimeError: [SCHEMA_MISMATCH_FOR_PANDAS_UDF] Result vector from pandas_udf was not the required length: expected 1, got 38. ``` The failure had not been captured because the test is missing in the `module.py` file. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closesapache#42568 from ueshin/issues/SPARK-44876/test_parity_arrow_python_udf. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes Arrow-optimized Python UDF on Spark Connect.
Also enables the missing test
pyspark.sql.tests.connect.test_parity_arrow_python_udf.Why are the changes needed?
pyspark.sql.tests.connect.test_parity_arrow_python_udfis not listed indev/sparktestsupport/modules.py, and it fails when running manually.The failure had not been captured because the test is missing in the
module.pyfile.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.