Uh oh!
There was an error while loading. Please reload this page.
[SPARK-45431][DOCS] Document new SSL RPC feature - #43240
Closed
hasnain-db wants to merge 4 commits into
Closed
Conversation
hasnain-dbforce-pushed
the
spark-tls-docs
branch
from
October 11, 2023 05:34
e71d443 to
7be2a62Comparehasnain-db
commented
Oct 30, 2023
ContributorAuthor
@mridulm could you look at this one when you have a chance? (or recommend a different reviewer if someone else is more suited to review docs PRs) |
mridulm
reviewed
Oct 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
mridulm
reviewed
Oct 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
mridulm
reviewed
Oct 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
mridulm
commented
Oct 30, 2023
Contributor
+CC @JoshRosen as well. |
hasnain-dbforce-pushed
the
spark-tls-docs
branch
from
October 30, 2023 20:32
a781f10 to
fa9ca55Comparemridulm
reviewed
Nov 7, 2023
mridulm
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good, except for the open discussion.
Sorry for the delay in reviewing this - not sure why I was not notified of the update by github ...
mridulm
commented
Nov 8, 2023
Contributor
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add some documentation to clarify the new flags being added and how this feature interacts with existing SSL and encryption support. It's a little confusing so feedback is welcome.
Note I am not sure if it's best practice to merge this after the feature is fully merged - thought I would put this up now since it's unblocked.
Why are the changes needed?
New features require documentation so users can understand how to use them.
Does this PR introduce any user-facing change?
Yes, this is adding documentation for a new feature
How was this patch tested?
Not applicable, this is documentation
Was this patch authored or co-authored using generative AI tooling?
No