Uh oh!
There was an error while loading. Please reload this page.
[SPARK-45429][CORE] Add helper classes for SSL RPC communication - #43244
[SPARK-45429][CORE] Add helper classes for SSL RPC communication#43244hasnain-db wants to merge 5 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
c70acd2 to
eaa7ec2Compare
mridulm
left a comment
There was a problem hiding this comment.
While waiting for tests, please fix the nit as well.
It wont impact the test result anyway
Uh oh!
There was an error while loading. Please reload this page.
hasnain-db
commented
Oct 14, 2023
|
mridulm
commented
Oct 14, 2023
Can you retrigger the tests please ? There are a bunch of failures. |
hasnain-db
commented
Oct 14, 2023
done, will re-request review once failures are minimized |
hasnain-db
commented
Oct 15, 2023
@mridulm I believe the only failure now is |
mridulm
commented
Oct 15, 2023
There was a failure in Thanks for working on this @hasnain-db ! |
What changes were proposed in this pull request?
This PR adds helper classes for SSL RPC communication that are needed to work around the fact that
nettydoes not support zero-copy transfers.These mirror the existing
MessageWithHeaderandMessageEncoderclasses with very minor differences. But the differences were just enough that it didn't seem easy to refactor/consolidate, and since we don't expect these classes to change much I hope it's ok.Why are the changes needed?
These are needed to support transferring
ManagedBuffers into a form that can be transferred bynettyover the network, since netty's encryption support does not support zero-copy transfers.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit tests
The rest of the changes and integration were tested as part of #42685
Was this patch authored or co-authored using generative AI tooling?
No