Uh oh!
There was an error while loading. Please reload this page.
[SPARK-45541][CORE] Add SSLFactory - #43386
Conversation
hasnain-db
commented
Oct 16, 2023
test failures looked unrelated, retrying now though. |
hasnain-db
commented
Oct 16, 2023
cc @mridulm@JoshRosen now that tests are green |
mridulm
left a comment
There was a problem hiding this comment.
Took a quick pass through the change, will go over the PR again in more detail later this week.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ed97d4d to
a1c0f41CompareUh oh!
There was an error while loading. Please reload this page.
mridulm
left a comment
There was a problem hiding this comment.
Just a couple of nits.
Can you update to master and retrigger the tests please ? Let us see if we can get a clean build (though the failures are not related)
Uh oh!
There was an error while loading. Please reload this page.
f18731e to
edf1a02Comparehasnain-db
commented
Oct 20, 2023
will re-request review once CI comes back |
Uh oh!
There was an error while loading. Please reload this page.
mridulm
left a comment
There was a problem hiding this comment.
Looks good to me, will wait for CI to succeed.
hasnain-db
commented
Oct 22, 2023
thanks! some jobs failed, rerunning them so hopefully there is a green CI in the morning |
mridulm
commented
Oct 22, 2023
The test failure is unrelated to this PR. Thanks for fixing this @hasnain-db ! |
What changes were proposed in this pull request?
As titled - add a factory which supports creating SSL engines, and a corresponding builder for it. This will be used in a follow up PR by the
TransportContextand related files to add SSL support.Why are the changes needed?
We need a mechanism to initialize the appropriate SSL implementation with the configured settings (such as protocol, ciphers, etc) for RPC SSL support.
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing tests. This will be more thoroughly tested in a follow up PR which adds callsites to it. It has been integration tested as part of #42685
Was this patch authored or co-authored using generative AI tooling?
No