Uh oh!
There was an error while loading. Please reload this page.
[SPARK-45709][BUILD] Deploy packages when all packages are built - #43561
Closed
EnricoMi wants to merge 1 commit into
Closed
[SPARK-45709][BUILD] Deploy packages when all packages are built#43561EnricoMi wants to merge 1 commit into
EnricoMi wants to merge 1 commit into
Conversation
EnricoMi
commented
Oct 27, 2023
ContributorAuthor
EnricoMi
commented
Nov 6, 2023
ContributorAuthor
@LuciferYang@HyukjinKwon the publish snapshot workflow keeps failing due to HTTP errors, which still causes inconsistent snapshot packages: https://github.com/apache/spark/actions/workflows/publish_snapshot.yml Please consider this fix. |
EnricoMi
commented
Dec 22, 2023
ContributorAuthor
@HyukjinKwon@LuciferYang this is still an issue: https://github.com/apache/spark/actions/runs/7294496840/job/19879448651 |
EnricoMiforce-pushed
the
publish-snapshot-deploy-at-end
branch
from
January 10, 2024 19:47
e9b8cf8 to
12554e4CompareWe're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Packages are deployed after all packages have been built. Currently, individual packages are deployed once they are built.
Why are the changes needed?
When some package fails to build (SPARK_45651), earlier packages have been published already, leading to an inconsistent set of latest snapshots, which might cause
ClassNotFoundExceptionslike in #43102 (comment). Packages should only be published once all have been built.Does this PR introduce any user-facing change?
No
How was this patch tested?
Locally:
./build/mvn deploybuilds all packages before it attempts to upload any.Was this patch authored or co-authored using generative AI tooling?
No