Uh oh!
There was an error while loading. Please reload this page.
[SPARK-46305][BUILD][SS] Remove Zookeeper 3.5.7 test dependency from the streaming-kafka-0-10 and sql-kafka-0-10 modules - #44230
Closed
LuciferYang wants to merge 2 commits into
Closed
[SPARK-46305][BUILD][SS] Remove Zookeeper 3.5.7 test dependency from the streaming-kafka-0-10 and sql-kafka-0-10 modules#44230LuciferYang wants to merge 2 commits into
3.5.7 test dependency from the streaming-kafka-0-10 and sql-kafka-0-10 modules#44230LuciferYang wants to merge 2 commits into
Conversation
streaming-kafka-0-10 and sql-kafka-0-10 test with the same zookeeper version as the projectstreaming-kafka-0-10 and sql-kafka-0-10 test with the same zookeeper version as the projectLuciferYang
marked this pull request as draft
December 7, 2023 07:05
LuciferYang
commented
Dec 7, 2023
ContributorAuthor
Test first |
LuciferYang
commented
Dec 7, 2023
| <groupId>org.apache.hadoop</groupId> | ||
| <artifactId>hadoop-minikdc</artifactId> | ||
| </dependency> | ||
| <!-- Kafka embedded server uses Zookeeper 3.5.7 API --> |
ContributorAuthor
There was a problem hiding this comment.
ContributorAuthor
There was a problem hiding this comment.
Currently, Spark uses Kafka 3.4.1, and its embedded server uses Zookeeper 3.6.4. If we wish to continue using a special version of Zookeeper in these two modules, please let me know.
streaming-kafka-0-10 and sql-kafka-0-10 test with the same zookeeper version as the projectstreaming-kafka-0-10 and sql-kafka-0-10 test with the same Zookeeper version as the projectstreaming-kafka-0-10 and sql-kafka-0-10 test with the same Zookeeper version as the projectstreaming-kafka-0-10 and sql-kafka-0-10 modulesstreaming-kafka-0-10 and sql-kafka-0-10 modulesstreaming-kafka-0-10 and sql-kafka-0-10 modulesLuciferYang
marked this pull request as ready for review
December 7, 2023 11:35
streaming-kafka-0-10 and sql-kafka-0-10 modules3.5.7 test dependency from the streaming-kafka-0-10 and sql-kafka-0-10 modulesdbatomic pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…m the `streaming-kafka-0-10` and `sql-kafka-0-10` modules ### What changes were proposed in this pull request? SPARK-31464 | apache#28235 specifies that the Zookeeper version used for testing in the `streaming-kafka-0-10` and `sql-kafka-0-10` modules is 3.5.7, while at that time, the default Zookeeper version used by Spark was 3.4.14. In SPARK-45956, the default Zookeeper version used by Spark was upgraded to 3.9.1, which is higher than both 3.5.7 and 3.6.4, the latter being used by the Kafka 3.4.1 embedded server. This PR try to make the `streaming-kafka-0-10` and `sql-kafka-0-10` modules also use the project's default Zookeeper version(3.9.1) for testing, rather than relying on a special version. ### Why are the changes needed? Make the `streaming-kafka-0-10` and `sql-kafka-0-10` modules use the default Zookeeper version of Spark for testing. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closesapache#44230 from LuciferYang/kafka-zk. Lead-authored-by: yangjie01 <yangjie01@baidu.com> Co-authored-by: YangJie <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-31464 | #28235 specifies that the Zookeeper version used for testing in the
streaming-kafka-0-10andsql-kafka-0-10modules is 3.5.7, while at that time, the default Zookeeper version used by Spark was 3.4.14.In SPARK-45956, the default Zookeeper version used by Spark was upgraded to 3.9.1, which is higher than both 3.5.7 and 3.6.4, the latter being used by the Kafka 3.4.1 embedded server. This PR try to make the
streaming-kafka-0-10andsql-kafka-0-10modules also use the project's default Zookeeper version(3.9.1) for testing, rather than relying on a special version.Why are the changes needed?
Make the
streaming-kafka-0-10andsql-kafka-0-10modules use the default Zookeeper version of Spark for testing.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No