Uh oh!
There was an error while loading. Please reload this page.
[SPARK-46432][BUILD] Upgrade Netty to 4.1.106.Final - #44384
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you check the CI failures?
panbingkun
commented
Dec 18, 2023
Okay, let me check it, I'll temporarily change PR to draft first. |
|
panbingkun
commented
Dec 18, 2023
Yes, I am fixing this issue. |
panbingkun
commented
Dec 18, 2023
A new pr for fix issued about |
dongjoon-hyun
commented
Dec 18, 2023
Thank you for the info, @panbingkun . |
LuciferYang
commented
Jan 23, 2024
@panbingkun Please rebase this PR, and I think the upgrade target can be 4.1.106, we can reuse this ticket |
dongjoon-hyun
commented
Jan 23, 2024
+1 for @LuciferYang 's comment. |
panbingkun
commented
Jan 24, 2024
Done. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Please regenerate the dependency file. It seems that there is a new entry like the following.
netty-transport-native-epoll/4.1.106.Final/linux-riscv64/netty-transport-native-epoll-4.1.106.Final-linux-riscv64.jar
panbingkun
commented
Jan 25, 2024
Can Spark run on the riscv64 machine? Can we exclude this dependency? If not, we still need to fix spark/common/network-yarn/pom.xml Lines 175 to 185 in b86053c |
| tofile="${project.build.directory}/exploded/META-INF/native/lib${spark.shade.native.packageName}_netty_transport_native_epoll_aarch_64.so" /> | ||
| <move file="${project.build.directory}/exploded/META-INF/native/libnetty_transport_native_kqueue_aarch_64.jnilib" | ||
| tofile="${project.build.directory}/exploded/META-INF/native/lib${spark.shade.native.packageName}_netty_transport_native_kqueue_aarch_64.jnilib" /> | ||
| <move file="${project.build.directory}/exploded/META-INF/native/libnetty_transport_native_epoll_riscv64.so" |
There was a problem hiding this comment.
Only this entry has been added, and the rest has been adjusted for indentation, from 4 spaces to 2 spaces.
panbingkun
commented
Jan 25, 2024
Done. |
LuciferYang
commented
Jan 25, 2024
In fact, I am more inclined to exclude this dependency. Because we do not yet have the corresponding CI to verify the usability of Apache Spark on RISC-V, so I personally think it is not supported on this architecture for the time being. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I'm fine with new entry. It doesn't mean Apache Spark claims any new additional architecture support. Could you reconsider your decision, @LuciferYang ?
netty-transport-native-epoll/4.1.106.Final/linux-aarch_64/netty-transport-native-epoll-4.1.106.Final-linux-aarch_64.jar
netty-transport-native-epoll/4.1.106.Final/linux-riscv64/netty-transport-native-epoll-4.1.106.Final-linux-riscv64.jar
netty-transport-native-epoll/4.1.106.Final/linux-x86_64/netty-transport-native-epoll-4.1.106.Final-linux-x86_64.jar
LuciferYang
left a comment
There was a problem hiding this comment.
ok, let's add this new dependency.
LuciferYang
commented
Jan 26, 2024
Merged into master for Spark 4.0. Thanks @panbingkun and @dongjoon-hyun ~ |
dongjoon-hyun
commented
Jan 26, 2024
Thank you, @panbingkun and @LuciferYang ! |

What changes were proposed in this pull request?
The pr aims to upgrade
Nettyfrom4.1.100.Finalto4.1.106.Final.Why are the changes needed?
To bring the latest bug fixes
Automatically close Http2StreamChannel when Http2FrameStreamExceptionreaches end ofChannelPipeline (#13651)
Symbol not found: _netty_jni_util_JNI_OnLoad (#13695)
4.1.106.Final release note: https://netty.io/news/2024/01/19/4-1-106-Final.html
4.1.105.Final release note: https://netty.io/news/2024/01/16/4-1-105-Final.html
4.1.104.Final release note: https://netty.io/news/2023/12/15/4-1-104-Final.html
4.1.103.Final release note: https://netty.io/news/2023/12/13/4-1-103-Final.html
4.1.101.Final release note: https://netty.io/news/2023/11/09/4-1-101-Final.html
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.