Uh oh!
There was an error while loading. Please reload this page.
[SPARK-46596][CORE][TESTS] Correct package name of SslTestUtils - #44596
[SPARK-46596][CORE][TESTS] Correct package name of SslTestUtils#44596LuciferYang wants to merge 2 commits into
SslTestUtils#44596Conversation
| */ | ||
| package org.apache.spark | ||
| package org.apache.spark.util |
There was a problem hiding this comment.
cc @dongjoon-hyun FYI
Moving this file to the core/src/test/scala/org/apache/spark/ directory is a solution that involves fewer changes. If you prefer to move the file instead of fixing the package name, please let me know.
There was a problem hiding this comment.
This looks like an incorrect package name - keeping it in util makes more sense.
Thanks for fixing this @LuciferYang !
MaxGekk
commented
Jan 4, 2024
The failure https://github.com/LuciferYang/spark/actions/runs/7409548578/job/20163613930 is not related to the changes, and I think it has been fixed by #44594. Let me merge this. |
MaxGekk
commented
Jan 4, 2024
+1, LGTM. Merging to master. |
LuciferYang
commented
Jan 5, 2024
Thanks @MaxGekk@mridulm and @dongjoon-hyun ~ |
What changes were proposed in this pull request?
The package name for
SslTestUtilsis defined asorg.apache.spark, but it is in theorg/apache/spark/util/directory. This pr corrects its package name to ensure consistency.Why are the changes needed?
Correct package name of
SslTestUtilsDoes this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No