Uh oh!
There was an error while loading. Please reload this page.
[SPARK-45807][SQL] Return View after calling replaceView(..) - #44970
Closed
nastra wants to merge 1 commit into
Closed
[SPARK-45807][SQL] Return View after calling replaceView(..)#44970nastra wants to merge 1 commit into
nastra wants to merge 1 commit into
Conversation
nastra
commented
Jan 31, 2024
ContributorAuthor
@cloud-fan@jzhuge since you both looked at #43677 in the past, could you also take a look at this one please? |
Contributor
There was a problem hiding this comment.
ContributorAuthor
There was a problem hiding this comment.
@cloud-fan do you mean adding This can be null if getting the metadata for the view is expensive to the javadoc? Sure I can do that, but the default implementation currently would always return the created view
Contributor
There was a problem hiding this comment.
Yea only change the doc for now. We will need to deal with null when implementing the v2 view commands.
ContributorAuthor
There was a problem hiding this comment.
I've updated the doc for create + replace view
nastraforce-pushed
the
SPARK-45807-return-type
branch
from
February 1, 2024 14:53
9657f97 to
59cbbb6Comparecloud-fan
approved these changes
Feb 1, 2024
nastraforce-pushed
the
SPARK-45807-return-type
branch
from
February 1, 2024 16:54
59cbbb6 to
c25effdComparecloud-fan
commented
Feb 2, 2024
Contributor
The test failure is unrelated, thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up API improvements based on from #43677
Why are the changes needed?
Required for DataSourceV2 view support.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
N/A