Uh oh!
There was an error while loading. Please reload this page.
[MINOR][DOCS] Clarify docs on default fractional numeric literals in SQL - #45027
Closed
nchammas wants to merge 2 commits into
Closed
[MINOR][DOCS] Clarify docs on default fractional numeric literals in SQL#45027nchammas wants to merge 2 commits into
nchammas wants to merge 2 commits into
Conversation
nchammas
commented
Feb 5, 2024
ContributorAuthor
Uh oh!
There was an error while loading. Please reload this page.
yaooqinn
approved these changes
Feb 6, 2024
yaooqinn
commented
Feb 6, 2024
Member
Thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide examples showing what type literals like
123.456and123.456E0have in SQL.Why are the changes needed?
In Python (and I think Java too) fractional numeric literals are typically floats. To get decimals, you need to provide an explicit postfix or use an explicit class. In Spark, it's the other way around. I found this surprising and couldn't find documentation about it.
I discovered this after reading SPARK-45786. I did a little searching and came across #10796, which shows that we used to default to floats as the fractional numeric literal, but then switched to decimals.
There is an additional wrinkle I discovered in #45003. If the fractional literal has an exponent, then it's a double, not a decimal.
The existing syntax documents this, but that alone is not user-friendly. The new examples make this clearer.
Does this PR introduce any user-facing change?
Yes, it clarifies the user-facing documentation about fractional numeric literals.
How was this patch tested?
No testing.
Was this patch authored or co-authored using generative AI tooling?
No.