Skip to content

[SPARK-48052][PYTHON][CONNECT] Recover pyspark-connect CI by parent classes - #46294

Closed
HyukjinKwon wants to merge 8 commits into
apache:masterfrom
HyukjinKwon:SPARK-48052
Closed

[SPARK-48052][PYTHON][CONNECT] Recover pyspark-connect CI by parent classes#46294
HyukjinKwon wants to merge 8 commits into
apache:masterfrom
HyukjinKwon:SPARK-48052

Conversation

@HyukjinKwon

@HyukjinKwonHyukjinKwon commented Apr 30, 2024

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR proposes to fix pyspark-connect build that is broken by #46155. It is similar with the followups such as #46229 and #46262 but make sure the tests pass within this PR.

Why are the changes needed?

To recover the CI https://github.com/apache/spark/actions/runs/8884003967

Does this PR introduce any user-facing change?

No, the main change has not been released yet.

How was this patch tested?

CI in my own fork: https://github.com/HyukjinKwon/spark/actions/runs/8889698252/job/24408487227

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon
HyukjinKwon marked this pull request as ready for review April 30, 2024 04:30

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

Merged to master.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HyukjinKwon@zhengruifeng@dongjoon-hyun