Uh oh!
There was an error while loading. Please reload this page.
[SPARK-48127][INFRA] Fix dev/scalastyle to check hadoop-cloud and jvm-profiler modules - #46376
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-48127][INFRA] Fix dev/scalastyle to check hadoop-cloud and jvm-profiler modules#46376dongjoon-hyun wants to merge 1 commit into
dev/scalastyle to check hadoop-cloud and jvm-profiler modules#46376dongjoon-hyun wants to merge 1 commit into
Conversation
… `jvm-profile` modules
dongjoon-hyun
commented
May 4, 2024
MemberAuthor
cc @panbingkun and @gengliangwang |
dongjoon-hyun
commented
May 4, 2024
MemberAuthor
All tests passed.  |
dongjoon-hyun
commented
May 4, 2024
MemberAuthor
Could you review this PR, @viirya ? |
viirya
approved these changes
May 4, 2024
viirya
commented
May 4, 2024
Member
Good catch! |
dongjoon-hyun
commented
May 4, 2024
MemberAuthor
Thank you, @viirya ! |
sinaiamonkar-sai pushed a commit
to sinaiamonkar-sai/spark
that referenced
this pull request
May 5, 2024
… `jvm-profiler` modules ### What changes were proposed in this pull request? This PR aims to fix `dev/scalastyle` to check `hadoop-cloud` and `jam-profiler` modules. Also, the detected scalastyle issues are fixed. ### Why are the changes needed? To prevent future scalastyle issues. Scala style violation was introduced here, but we missed because we didn't check all optional modules. - apache#46022 `jvm-profiler` module was added newly at Apache Spark 4.0.0 but we missed to add this to `dev/scalastyle`. Note that there was no scala style issues in that `module` at that time. - apache#44021 `hadoop-cloud` module was added at Apache Spark 2.3.0. - apache#17834 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with newly revised `dev/scalastyle`. ### Was this patch authored or co-authored using generative AI tooling? No. Closesapache#46376 from dongjoon-hyun/SPARK-48127. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Contributor
late LGTM. |
dongjoon-hyun pushed a commit
that referenced
this pull request
May 9, 2024
…-ganglia-lgpl` and `jvm-profiler` to `sbt-checkstyle` ### What changes were proposed in this pull request? The pr aims to add - `spark-ganglia-lgpl` to `lint-java` - `spark-ganglia-lgpl` and `jvm-profiler` to `sbt-checkstyle` ### Why are the changes needed? 1.Because the module `spark-ganglia-lgpl` has `java` code 2.Because the module `spark-ganglia-lgpl` & `jvm-profiler` has `scala` code 3.Although these module codes currently comply with the specification, in order to avoid problems like #46376, they will occur again in future modifications. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manually test. - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes#46501 from panbingkun/minor_spark-ganglia-lgpl. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
dev/scalastyleto checkhadoop-cloudandjam-profilermodules.Also, the detected scalastyle issues are fixed.
Why are the changes needed?
To prevent future scalastyle issues.
Scala style violation was introduced here, but we missed because we didn't check all optional modules.
jvm-profilermodule was added newly at Apache Spark 4.0.0 but we missed to add this todev/scalastyle. Note that there was no scala style issues in thatmoduleat that time.hadoop-cloudmodule was added at Apache Spark 2.3.0.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with newly revised
dev/scalastyle.Was this patch authored or co-authored using generative AI tooling?
No.