Uh oh!
There was an error while loading. Please reload this page.
[SPARK-48137][INFRA] Run yarn test only in PR builders and Daily CIs - #46395
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-48137][INFRA] Run yarn test only in PR builders and Daily CIs#46395dongjoon-hyun wants to merge 1 commit into
yarn test only in PR builders and Daily CIs#46395dongjoon-hyun wants to merge 1 commit into
Conversation
yarn test only in PR builders and Maven Daily CIsyarn test only in PR builders and Daily CIsdongjoon-hyunforce-pushed
the
SPARK-48137
branch
2 times, most recently
from
May 6, 2024 02:45
92fd00c to
7b81debComparedongjoon-hyun
marked this pull request as draft
May 6, 2024 02:47
dongjoon-hyun
commented
May 6, 2024
MemberAuthor
WDYT, @HyukjinKwon ? |
dongjoon-hyun
marked this pull request as ready for review
May 6, 2024 02:59
dongjoon-hyun
commented
May 6, 2024
MemberAuthor
Alternatively, we can ignore |
dongjoon-hyun
commented
May 6, 2024
MemberAuthor
Could you review this PR too, @LuciferYang ? |
dongjoon-hyun
commented
May 6, 2024
MemberAuthor
Thank you so much! Merged to master~ |
| pyspark=`./dev/is-changed.py -m $pyspark_modules` | ||
| if [[ "${{ github.repository }}" != 'apache/spark' ]]; then | ||
| pandas=$pyspark | ||
| yarn=`./dev/is-changed.py -m yarn` |
Contributor
There was a problem hiding this comment.
Sorry, I just reviewed modules.py and have a small question: if the common/network-yarn module has changed, should yarn also be set to true?
MemberAuthor
There was a problem hiding this comment.
Yes, source_file_regexes has common/network-yarn and I believe it makes sense.
spark/dev/sparktestsupport/modules.py
Lines 1447 to 1460 in 7c728b2
dongjoon-hyun added a commit
that referenced
this pull request
May 7, 2024
### What changes were proposed in this pull request? This PR aims to merge connect back to the original test pipeline to reduce the maximum concurrency of GitHub Action by one. - https://infra.apache.org/github-actions-policy.html > All workflows SHOULD have a job concurrency level less than or equal to 15. ### Why are the changes needed? This is a partial recover from the following. - #45107 We stabilized the root cause of #45107 via the following PRs. In addition we will disable a flaky test case if exists. - #46395 - #46396 - #46425 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes#46441 from dongjoon-hyun/SPARK-48174. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have been providing a dedicated test environment for
yarnandconnectmodule because they are flaky.yarnandconnect#45107However, they are still flaky. So, this PR aims to run
yarntest only in PR builders (if needed) and Daily CIs (always).YARN CIonly when we need to testYARNmodule.connectflakiness by providing an independent GitHub Action environment in PR Builders and Daily CIs.Why are the changes needed?
PR builders provide an extensive test coverage with YARN testing.
Daily CIs with YARN tests
YARN CI has been flaky in GitHub Action environment and requires irrelevant re-tries very frequently.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.