[SPARK-48031][SQL][FOLLOW-UP] Use ANSI-enabled cast in view lookup test - #46614
Closed
HyukjinKwon wants to merge 1 commit into
Closed
[SPARK-48031][SQL][FOLLOW-UP] Use ANSI-enabled cast in view lookup test#46614HyukjinKwon wants to merge 1 commit into
HyukjinKwon wants to merge 1 commit into
Conversation
Contributor
|
@HyukjinKwon Any idea why this did not trip the original PR? |
Member
Author
|
because we don't run the tests without ANSI in PR builder (because of resource limitation). It only runs in the daily build defined here https://github.com/apache/spark/actions/workflows/build_non_ansi.yml |
cloud-fan
approved these changes
May 16, 2024
yaooqinn
approved these changes
May 16, 2024
Member
Author
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #46267 that uses ANSI-enabled cast in the tests. It intentionally uses ANSI-enabled cast in
castColToTypewhen you look up a view.Why are the changes needed?
In order to fix the scheduled CI build without ANSI:
Does this PR introduce any user-facing change?
No, the main change has not been released yet.
How was this patch tested?
Manually ran the tests after ANSI disabled.
Was this patch authored or co-authored using generative AI tooling?
No.