Uh oh!
There was an error while loading. Please reload this page.
[SPARK-47552][CORE][FOLLOWUP] Set spark.hadoop.fs.s3a.connection.establish.timeout to numeric - #46874
[SPARK-47552][CORE][FOLLOWUP] Set spark.hadoop.fs.s3a.connection.establish.timeout to numeric#46874cloud-fan wants to merge 1 commit into
Conversation
cloud-fan
commented
Jun 5, 2024
yaooqinn
commented
Jun 5, 2024
It looks more reasonable to use |
cloud-fan
commented
Jun 5, 2024
@yaooqinn It still uses |
yaooqinn
commented
Jun 5, 2024
It's irrelevant to your PR. I mean #45710 brought this behavioral change. If a user defines |
cloud-fan
commented
Jun 5, 2024
also cc @viirya |
viirya
commented
Jun 6, 2024
For the purpose of this follow up, it looks good. For the question, if |
cloud-fan
commented
Jun 6, 2024
let me merge this follow-up first. We can continue the discussion in the original PR. |
…timeout` setting ### What changes were proposed in this pull request? This PR aims to remove `spark.hadoop.fs.s3a.connection.establish.timeout` setting from `SparkContext` because Apache Spark 4.0.0 uses Apache Hadoop 3.4.1 which has the same default value. - #48295 ### Why are the changes needed? This is a logical cleanup by reverting two patches. - #45710 - #46874 ### Does this PR introduce _any_ user-facing change? No. There is no behavior change because we will use the same `fs.s3a.connection.establish.timeout` value. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes#49376 from dongjoon-hyun/SPARK-50742. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
This is a followup of #45710 . Some custom
FileSystemimplementations read thehadoop.fs.s3a.connection.establish.timeoutconfig as numeric, and do not support the30ssyntax. To make it safe, this PR proposes to set this conf to30000instead of30s. I checked the doc page and this config is milliseconds.Why are the changes needed?
more compatible with custom
FileSystemimplementations.Does this PR introduce any user-facing change?
no
How was this patch tested?
manual
Was this patch authored or co-authored using generative AI tooling?
no