Uh oh!
There was an error while loading. Please reload this page.
[SPARK-48792][SQL] Fix regression for INSERT with partial column list to a table with char/varchar - #47198
Closed
yaooqinn wants to merge 2 commits into
Closed
[SPARK-48792][SQL] Fix regression for INSERT with partial column list to a table with char/varchar#47198yaooqinn wants to merge 2 commits into
yaooqinn wants to merge 2 commits into
Conversation
…able with char/varchar
yaooqinn
marked this pull request as draft
July 3, 2024 09:32
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
yaooqinn
marked this pull request as ready for review
July 3, 2024 12:04
cloud-fan
approved these changes
Jul 3, 2024
yaooqinn
commented
Jul 5, 2024
MemberAuthor
Merged to master, thank you for the review @cloud-fan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#41262 introduced a regression by applying literals with char/varchar type in query output for table insertions, see
https://github.com/apache/spark/pull/41262/files#diff-6e331e8f1c67b5920fb46263b6e582ec6e6a253ee45543559c9692a72a1a40ecR187-R188
This causes bugs
Why are the changes needed?
Bugfix
Does this PR introduce any user-facing change?
no
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no