Uh oh!
There was an error while loading. Please reload this page.
[SPARK-6024][SQL] When a data source table has too many columns, it's schema cannot be stored in metastore. - #4795
[SPARK-6024][SQL] When a data source table has too many columns, it's schema cannot be stored in metastore.#4795yhuai wants to merge 6 commits into
Conversation
SparkQA
commented
Feb 26, 2015
Test build #28020 has started for PR 4795 at commit
|
SparkQA
commented
Feb 26, 2015
Test build #28022 has started for PR 4795 at commit
|
SparkQA
commented
Feb 26, 2015
Test build #28020 has finished for PR 4795 at commit
|
AmplabJenkins
commented
Feb 26, 2015
Test PASSed. |
There was a problem hiding this comment.
why don't we just always use schema.part.0 ? seems easier to consolidate the two code path
SparkQA
commented
Feb 26, 2015
Test build #28022 has finished for PR 4795 at commit
|
AmplabJenkins
commented
Feb 26, 2015
Test PASSed. |
SparkQA
commented
Feb 26, 2015
Test build #28025 has started for PR 4795 at commit
|
SparkQA
commented
Feb 27, 2015
Test build #28025 has finished for PR 4795 at commit
|
AmplabJenkins
commented
Feb 27, 2015
Test PASSed. |
There was a problem hiding this comment.
I think it is more conventional to use numParts instead of numOfParts. Also you can remove the pattern matching by just applying a map.
Option(table.getProperty("spark.sql.sources.schema.numParts")).map { numParts =>
...
}SparkQA
commented
Feb 27, 2015
Test build #28031 has started for PR 4795 at commit
|
There was a problem hiding this comment.
sorry for being picky, but it would be great to include the reason why it is corrupted (i.e. "missing part x")
SparkQA
commented
Feb 27, 2015
Test build #28031 has finished for PR 4795 at commit
|
AmplabJenkins
commented
Feb 27, 2015
Test PASSed. |
SparkQA
commented
Feb 27, 2015
Test build #28043 has started for PR 4795 at commit
|
rxin
commented
Feb 27, 2015
lgtm |
SparkQA
commented
Feb 27, 2015
Test build #28043 has finished for PR 4795 at commit
|
AmplabJenkins
commented
Feb 27, 2015
Test PASSed. |
rxin
commented
Feb 27, 2015
Merging in! |
… schema cannot be stored in metastore. JIRA: https://issues.apache.org/jira/browse/SPARK-6024 Author: Yin Huai <yhuai@databricks.com> Closes#4795 from yhuai/wideSchema and squashes the following commits: 4882e6f [Yin Huai] Address comments. 73e71b4 [Yin Huai] Address comments. 143927a [Yin Huai] Simplify code. cc1d472 [Yin Huai] Make the schema wider. 12bacae [Yin Huai] If the JSON string of a schema is too large, split it before storing it in metastore. e9b4f70 [Yin Huai] Failed test. (cherry picked from commit 5e5ad65) Signed-off-by: Reynold Xin <rxin@databricks.com>
JIRA: https://issues.apache.org/jira/browse/SPARK-6024