Skip to content

[SPARK-6058][Yarn] Log the user class exception in ApplicationMaster - #4813

Closed
zsxwing wants to merge 1 commit into
apache:masterfrom
zsxwing:SPARK-6058
Closed

[SPARK-6058][Yarn] Log the user class exception in ApplicationMaster#4813
zsxwing wants to merge 1 commit into
apache:masterfrom
zsxwing:SPARK-6058

Conversation

@zsxwing

@zsxwingzsxwing commented Feb 27, 2015

Copy link
Copy Markdown
Member

Because ApplicationMaster doesn't set SparkUncaughtExceptionHandler, the exception in the user class won't be logged. This PR added a logError for it.

@SparkQA

SparkQA commented Feb 27, 2015

Copy link
Copy Markdown

Test build #28060 has started for PR 4813 at commit 806c932.

  • This patch merges cleanly.

@lianhuiwang

lianhuiwang commented Feb 27, 2015

Copy link
Copy Markdown
Contributor

LGTM

@srowen

srowen commented Feb 27, 2015

Copy link
Copy Markdown
Member

OK, this is basically an addendum to SPARK-6018 and should follow it. Throwing the exception from a raw Thread won't log it by itself, and it seems the intent was to log the error. Seems fine to explicitly log this and then not throw. LGTM.

@SparkQA

SparkQA commented Feb 27, 2015

Copy link
Copy Markdown

Test build #28060 timed out for PR 4813 at commit 806c932 after a configured wait of 120m.

@AmplabJenkins

AmplabJenkins commented Feb 27, 2015

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28060/
Test FAILed.

@zsxwing

zsxwing commented Feb 27, 2015

Copy link
Copy Markdown
MemberAuthor

Jenkins, retest this please.

@srowen

srowen commented Feb 27, 2015

Copy link
Copy Markdown
Member

Jenkins, retest this please

@SparkQA

SparkQA commented Feb 27, 2015

Copy link
Copy Markdown

Test build #28067 has started for PR 4813 at commit 806c932.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Feb 27, 2015

Copy link
Copy Markdown

Test build #28067 has finished for PR 4813 at commit 806c932.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • logError("User class threw exception: " + cause.getMessage, cause)

@AmplabJenkins

AmplabJenkins commented Feb 27, 2015

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28067/
Test PASSed.

asfgit pushed a commit that referenced this pull request Feb 27, 2015
@zsxwing@srowen
[SPARK-6058][Yarn] Log the user class exception in ApplicationMaster
bff8088
Because ApplicationMaster doesn't set SparkUncaughtExceptionHandler, the exception in the user class won't be logged. This PR added a `logError` for it.
Author: zsxwing <zsxwing@gmail.com>
Closes#4813 from zsxwing/SPARK-6058 and squashes the following commits:
806c932 [zsxwing] Log the user class exception
(cherry picked from commit e747e98)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@zsxwing
zsxwing deleted the SPARK-6058 branch February 28, 2015 02:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zsxwing@SparkQA@lianhuiwang@srowen@AmplabJenkins