Skip to content

[SPARK-6179][SQL] Add token for "SHOW PRINCIPALS role_name" and "SHOW TRANSACTIONS" and "SHOW COMPACTIONS" - #4902

Closed
pzzs wants to merge 11 commits into
apache:masterfrom
pzzs:SHOW_PRINCIPALS
Closed

[SPARK-6179][SQL] Add token for "SHOW PRINCIPALS role_name" and "SHOW TRANSACTIONS" and "SHOW COMPACTIONS"#4902
pzzs wants to merge 11 commits into
apache:masterfrom
pzzs:SHOW_PRINCIPALS

Conversation

@pzzs

@pzzspzzs commented Mar 5, 2015

Copy link
Copy Markdown
Contributor

[SHOW PRINCIPALS role_name]
Lists all roles and users who belong to this role.
Only the admin role has privilege for this.

[SHOW COMPACTIONS]
It returns a list of all tables and partitions currently being compacted or scheduled for compaction when Hive transactions are being used.

[SHOW TRANSACTIONS]
It is for use by administrators when Hive transactions are being used. It returns a list of all currently open and aborted transactions in the system.

@chenghao-intel

Copy link
Copy Markdown
Contributor

We initially implemented the HiveQL.scala upon the Hive 0.12 only, and I believe there are some other Hive native commands need to be added for Hive 0.13.1 compatibility, it will be great if you can review the Hive Native command list and add them all.

By the way, can you also add a unit test for this? In case we misspell the keyword.

@pzzs

pzzs commented Mar 5, 2015

Copy link
Copy Markdown
ContributorAuthor

OK. I will add a unit test. @chenghao-intel

@marmbrus

Copy link
Copy Markdown
Contributor

ok to test

@SparkQA

Copy link
Copy Markdown

Test build #28312 has finished for PR 4902 at commit 0dd37b4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pzzspzzs changed the title [SPARK-6179][SQL] "SHOW PRINCIPALS role_name;"[SPARK-6179][SQL] Add token for "SHOW PRINCIPALS role_name" and "SHOW TRANSACTIONS" and "SHOW COMPACTIONS"Mar 9, 2015
@pzzs

pzzs commented Mar 9, 2015

Copy link
Copy Markdown
ContributorAuthor

I add other two tokens. Could you test it again? @marmbrus

@SparkQA

Copy link
Copy Markdown

Test build #28383 has finished for PR 4902 at commit 9d8fd71.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pzzs

pzzs commented Mar 12, 2015

Copy link
Copy Markdown
ContributorAuthor

/cc @marmbrus

@SparkQA

Copy link
Copy Markdown

Test build #29198 has finished for PR 4902 at commit ec8bc94.

  • This patch fails Scala style tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #29200 has finished for PR 4902 at commit c8aeb1c.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class UnregisterApplication(appId: String)
    • class RegexTokenizer extends UnaryTransformer[String, Seq[String], RegexTokenizer]
    • case class Data(weight: Double, mu: Vector, sigma: Matrix)

@SparkQA

Copy link
Copy Markdown

Test build #29201 has finished for PR 4902 at commit 0c7550a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #29774 has finished for PR 4902 at commit 4add42f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@marmbrus

Copy link
Copy Markdown
Contributor

Thanks, merged to master.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pzzs@chenghao-intel@marmbrus@SparkQA@XuTingjun