Uh oh!
There was an error while loading. Please reload this page.
[SPARK-50780][SQL] Use overrideStdFeatures instead of setFeatureMask in JacksonParser - #49434
Closed
LuciferYang wants to merge 2 commits into
Closed
[SPARK-50780][SQL] Use overrideStdFeatures instead of setFeatureMask in JacksonParser#49434LuciferYang wants to merge 2 commits into
overrideStdFeatures instead of setFeatureMask in JacksonParser#49434LuciferYang wants to merge 2 commits into
Conversation
LuciferYang
marked this pull request as draft
January 10, 2025 05:33
overrideStdFeatures instead of setFeatureMaskoverrideStdFeatures instead of setFeatureMaskLuciferYang
commented
Jan 10, 2025
| // which is a bitmask with all bits set, effectively allowing all features | ||
| // to be reset. This ensures that every feature is restored to its previous | ||
| // state as defined by `oldFeature`. | ||
| parser.overrideStdFeatures(oldFeature, ~0) |
ContributorAuthor
There was a problem hiding this comment.
can also use a seat mask of -1 to restore the state, as long as all the bits are set to 1.
overrideStdFeatures instead of setFeatureMaskoverrideStdFeatures instead of setFeatureMask for JsonParseroverrideStdFeatures instead of setFeatureMask for JsonParseroverrideStdFeatures instead of setFeatureMask in JacksonParserLuciferYang
marked this pull request as ready for review
January 10, 2025 08:49
dongjoon-hyun
approved these changes
Jan 10, 2025
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
dongjoon-hyun
commented
Jan 10, 2025
Member
Merged to master for Apache Spark 4.0.0. |
LuciferYang
commented
Jan 11, 2025
ContributorAuthor
Thanks @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #49018, the restoration logic for feature flags was fixed using the
setFeatureMaskmethod. However, thesetFeatureMaskmethod has been deprecated since Jackson 2.7, so this pr reimplements the relevant logic usingoverrideStdFeatures.Why are the changes needed?
Clean up the use of deprecated APIs.
https://github.com/FasterXML/jackson-core/blob/0d2b0f39200d466f49f1abb06d9027053d41483d/src/main/java/com/fasterxml/jackson/core/JsonParser.java#L999-L1035
Does this PR introduce any user-facing change?
No
How was this patch tested?
JacksonParserSuite.Was this patch authored or co-authored using generative AI tooling?
No