Uh oh!
There was an error while loading. Please reload this page.
[SPARK-6067][SQL]delete the file with the same name before create the path for HiveFileFormatUtils.getHiveRecordWriter - #4980
Conversation
baishuo
commented
Mar 11, 2015
I think this patch should test by the Reporter of SPARK-6067 |
marmbrus
commented
Apr 3, 2015
ok to test |
marmbrus
commented
Apr 3, 2015
/cc @liancheng |
SparkQA
commented
Apr 3, 2015
Test build #29636 has finished for PR 4980 at commit
|
There was a problem hiding this comment.
Maybe check for part- before getting a file system or checking if the file exists. This saves RPCs.
Did you mean > 0 in the sense of contains? that's not quite correct if so, since the condition should be >= 0. But then contains would be simpler anyway.
Finally, duplicat -> duplicate
baishuo
commented
Apr 23, 2015
thank you @srowen |
SparkQA
commented
Apr 23, 2015
Test build #30804 has finished for PR 4980 at commit
|
SparkQA
commented
Apr 27, 2015
Test build #31055 has started for PR 4980 at commit |
There was a problem hiding this comment.
As @srowen mentioned, please check "part-" first, and then check existence, to save NameNode RPC.
SparkQA
commented
Apr 29, 2015
Test build #31228 has finished for PR 4980 at commit
|
baishuo
commented
Apr 30, 2015
can this patch be merged?:) |
andrewor14
commented
Sep 2, 2015
@liancheng can this patch be merged? Is it still relevant? |
baishuo
commented
Sep 9, 2015
hi @andrewor14@liancheng , I think this is a useful patch :) |
liancheng
commented
Sep 18, 2015
Seems that this issue has already fixed by #6833? |
andrewor14
commented
Sep 18, 2015
Shall we close this PR then? |
baishuo
commented
Sep 19, 2015
no problem. close it :) @andrewor14@liancheng |
this is commit for https://issues.apache.org/jira/browse/SPARK-6067