Skip to content

[Fix #79] Replace Breakable For Loops By While Loops - #503

Closed
techaddict wants to merge 3 commits into
apache:masterfrom
techaddict:fix-79
Closed

[Fix #79] Replace Breakable For Loops By While Loops#503
techaddict wants to merge 3 commits into
apache:masterfrom
techaddict:fix-79

Conversation

@techaddict

@techaddicttechaddict commented Apr 23, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@AmplabJenkins

AmplabJenkins commented Apr 23, 2014

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mateiz

mateiz commented Apr 23, 2014

Copy link
Copy Markdown
Contributor

Jenkins, test this please

@AmplabJenkins

AmplabJenkins commented Apr 23, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Apr 23, 2014

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Apr 23, 2014

Copy link
Copy Markdown

Merged build finished.

@AmplabJenkins

AmplabJenkins commented Apr 23, 2014

Copy link
Copy Markdown

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14406/

@techaddict

techaddict commented Apr 24, 2014

Copy link
Copy Markdown
ContributorAuthor

@mateiz retest this please, I think failure is due to some other PR, as these changes have nothing to do with Streaming.

@rxin

rxin commented Apr 24, 2014

Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

rxin
rxin reviewed Apr 24, 2014
View reviewed changes
Comment threadmllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala Outdated

@rxinrxinApr 24, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per Spark style guide, can you change this to include curly braces, e.g.

if (allLeaf) {
break =true
} else {
level +=1
}

Thanks.

@AmplabJenkins

AmplabJenkins commented Apr 24, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Apr 24, 2014

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Apr 24, 2014

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

AmplabJenkins commented Apr 24, 2014

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14424/

@techaddict

techaddict commented Apr 24, 2014

Copy link
Copy Markdown
ContributorAuthor

@rxin all suggested changes done, tests passed

@rxin

rxin commented Apr 24, 2014

Copy link
Copy Markdown
Contributor

Thanks. I've merged this.

asfgit pushed a commit that referenced this pull request Apr 24, 2014
@techaddict@rxin
[Fix#79] Replace Breakable For Loops By While Loops
e890771
Author: Sandeep <sandeep@techaddict.me>
Closes#503 from techaddict/fix-79 and squashes the following commits:
e3f6746 [Sandeep] Style changes
07a4f6b [Sandeep] for loop to While loop
0a6d8e9 [Sandeep] Breakable for loop to While loop
(cherry picked from commit bb68f47)
Signed-off-by: Reynold Xin <rxin@apache.org>
pwendell added a commit to pwendell/spark that referenced this pull request May 12, 2014
@pwendell
Merge pull requestapache#503from pwendell/master
3d6e754
Fix bug on read-side of external sort when using Snappy.
This case wasn't handled correctly and this patch fixes it.
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@techaddict@pdeyhim
[Fixapache#79] Replace Breakable For Loops By While Loops
32a363b
Author: Sandeep <sandeep@techaddict.me>
Closesapache#503 from techaddict/fix-79 and squashes the following commits:
e3f6746 [Sandeep] Style changes
07a4f6b [Sandeep] for loop to While loop
0a6d8e9 [Sandeep] Breakable for loop to While loop
andrewor14 pushed a commit to andrewor14/spark that referenced this pull request Jan 8, 2015
@pwendell
Merge pull requestapache#503from pwendell/master
e66d4c2
Fix bug on read-side of external sort when using Snappy.
This case wasn't handled correctly and this patch fixes it.
(cherry picked from commit 3d6e754)
Signed-off-by: Patrick Wendell <pwendell@gmail.com>
mccheah referenced this pull request in palantir/spark Sep 26, 2017
@liyinan926@mccheah
Removing deprecated configuration (#503)
0dff8be
Replaced #501 by @foxish.
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Nov 7, 2017
@liyinan926@foxish
Removing deprecated configuration (apache#503)
3c1a16a
Replaced apache#501 by @foxish.
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
@Yikun@liusheng
Add periodic job for envoy and containerd (apache#503)
227a942
* Add support for config-gcc role
You can use below config to enbale gcc-7:
```
roles:
- role: config-gcc
gcc_version: 7
```
Close-issue: theopenlab/openlab#239
* Add periodic job for envoy and containerd
This patch add the periodic jobs for envoy and containerd arm
build.
- containerd-build-arm64
- envoy-build-arm64
arjunshroff pushed a commit to arjunshroff/spark that referenced this pull request Nov 24, 2020
@mgorbov@ekrivokonmapr
MapR [SPARK-540] Include 'avro' artifacts (apache#503)
cac5fdf
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@techaddict@AmplabJenkins@mateiz@rxin