Uh oh!
There was an error while loading. Please reload this page.
[SPARK-51629][UI] Add a download link on the ExecutionPage for svg/dot/txt format plans - #50427
Closed
yaooqinn wants to merge 3 commits into
Closed
[SPARK-51629][UI] Add a download link on the ExecutionPage for svg/dot/txt format plans#50427yaooqinn wants to merge 3 commits into
yaooqinn wants to merge 3 commits into
Conversation
yaooqinn
commented
Mar 27, 2025
| */ | ||
| #plan-viz-graph .label { | ||
| svg g.label { |
MemberAuthor
There was a problem hiding this comment.
The inlined style to the exported SVG does not have the plan-viz-graph div as a container
yaooqinn
commented
Mar 27, 2025
MemberAuthor
cc @dongjoon-hyun@HyukjinKwon@cloud-fan thank you |
dongjoon-hyun
approved these changes
Mar 27, 2025
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Nice, @yaooqinn !
yaooqinn
commented
Mar 28, 2025
MemberAuthor
Thank you @dongjoon-hyun Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a download link to the ExecutionPage for SVG/dot/txt format plans.

Why are the changes needed?
These downloaded assets can improve the UX for sharing/porting to papers, social media, external advanced visualization tools, e.t.c.
Does this PR introduce any user-facing change?
Yes, UI changes
How was this patch tested?
plan.txt
Was this patch authored or co-authored using generative AI tooling?
no