Uh oh!
There was an error while loading. Please reload this page.
[DRAFT] Parameter markers in DDL. - #51410
Closed
srielau wants to merge 13 commits into
Closed
Conversation
| "'" + st.typeName.substring(6) | ||
| case (v: Byte, ByteType) => s"${v}Y" | ||
| case (v: Short, ShortType) => s"${v}S" | ||
| case (v: Int, IntegerType) => s"${v}" |
Contributor
There was a problem hiding this comment.
This is the same as the last catch-all case: case _ => value.toString
ContributorAuthor
There was a problem hiding this comment.
Yes, I suspected as much. However I thought it useful to be explicit.
In fact I'm wondering whether we should remove the catch-all in favor of an error. Wonder what we would fine....
dongjoon-hyun
marked this pull request as draft
August 30, 2025 20:22
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?