Uh oh!
There was an error while loading. Please reload this page.
[SPARK-53001][CORE][SQL][FOLLOW-UP] Disable spark.memory.unmanagedMemoryPollingInterval by default - #51778
Closed
ericm-db wants to merge 1 commit into
Closed
[SPARK-53001][CORE][SQL][FOLLOW-UP] Disable spark.memory.unmanagedMemoryPollingInterval by default#51778ericm-db wants to merge 1 commit into
spark.memory.unmanagedMemoryPollingInterval by default#51778ericm-db wants to merge 1 commit into
Conversation
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
Thank you for making a quick followup, @ericm-db .
| .version("4.1.0") | ||
| .timeConf(TimeUnit.MILLISECONDS) | ||
| .createWithDefaultString("1s") | ||
| .createWithDefaultString("0s") |
| } | ||
| // Check for memory tracking - the continuous stream should trigger memory updates | ||
| var initialRocksDBMemory = 0L | ||
| eventually(timeout(Span(20, Seconds)), interval(Span(500, Millis))) { |
Member
There was a problem hiding this comment.
Thank you for the change. Let's see the CI result.
spark.memory.unmanagedMemoryPollingInterval by defaultspark.memory.unmanagedMemoryPollingInterval by defaultspark.memory.unmanagedMemoryPollingInterval by defaultericm-db
commented
Aug 1, 2025
ContributorAuthor
@dongjoon-hyun This job keeps timing out, but the tests are passing - I think there are simply too many tests to run here. |
dongjoon-hyun
commented
Aug 1, 2025
Member
Ya, you are correct. I'm trying to rebalance the CI via the following. |
dongjoon-hyun
approved these changes
Aug 1, 2025
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM.
I verified this manually.
$ build/sbt "sql/testOnly *.RocksDBStateStoreIntegrationSuite"
...
[info] Run completed in 19 seconds, 890 milliseconds.
[info] Total number of tests run: 29
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 29, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 83 s (01:23), completed Aug 1, 2025, 1:56:13 PM
ericm-db
commented
Aug 1, 2025
ContributorAuthor
Great, thanks for the help and the feedback here @dongjoon-hyun ! |
dongjoon-hyun
commented
Aug 1, 2025
Member
Merged to master. Thank YOU, @ericm-db . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow up of #51708, addressing nits and test feedback
Why are the changes needed?
To conform with Spark style standards and make tests less flaky
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No