Skip to content

[SPARK-51756][CORE][FOLLOWUP] Avoid the risk of overflow of long #52776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beliefer wants to merge 1 commit into from
+1 −1
Closed

[SPARK-51756][CORE][FOLLOWUP] Avoid the risk of overflow of long #52776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/spark/shuffle/checksum/RowBasedChecksum.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ abstract class RowBasedChecksum() extends Serializable with Logging {
object RowBasedChecksum {
def getAggregatedChecksumValue(rowBasedChecksums: Array[RowBasedChecksum]): Long = {
Option(rowBasedChecksums)
.map(_.foldLeft(0L)((acc, c) => acc * 31L + c.getValue))
.map(_.foldLeft(0L)((acc, c) => (acc * 31L + c.getValue) & Long.MaxValue))

@cloud-fan cloud-fan Oct 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does & Long.MaxValue help here? The current code is kind of very common and many hash code are also calculated like this.

.getOrElse(0L)
}
}