Uh oh!
There was an error while loading. Please reload this page.
[SPARK-54132][SQL][TESTS] Cover HashedRelation#close in HashedRelationSuite - #52830
Closed
zhztheplayer wants to merge 1 commit into
Closed
[SPARK-54132][SQL][TESTS] Cover HashedRelation#close in HashedRelationSuite#52830zhztheplayer wants to merge 1 commit into
zhztheplayer wants to merge 1 commit into
Conversation
zhztheplayer
commented
Nov 3, 2025
MemberAuthor
@HyukjinKwon@yaooqinn@wangyum@cloud-fan Could you please review? Thanks! |
cloud-fan
approved these changes
Nov 3, 2025
cloud-fan
commented
Nov 3, 2025
Contributor
thanks, merging to master/4.1 (for test coverage)! |
cloud-fan pushed a commit
that referenced
this pull request
Nov 3, 2025
…nSuite
### What changes were proposed in this pull request?
Add the following code in `HashedRelationSuite`, to cover the API `HashedRelation#close` in the test suite.
```scala
protected override def afterEach(): Unit = {
super.afterEach()
assert(umm.executionMemoryUsed === 0)
}
```
### Why are the changes needed?
Doing this will:
1. Ensure `HashedRelation#close` is called in test code, to lower memory footprint and avoid memory leak when executing tests.
2. Ensure implementations of `HashedRelation#close` free the allocated memory blocks correctly.
It's an individual effort to improve the test quality, but also a prerequisite task for #52817.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
It's a test PR.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes#52830 from zhztheplayer/wip-54132.
Authored-by: Hongze Zhang <hongze.zzz123@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit a5e866f)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>zhztheplayer
commented
Nov 3, 2025
MemberAuthor
Thanks, @cloud-fan! |
yaooqinn
commented
Nov 4, 2025
Member
Late LGTM |
huangxiaopingRD pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…nSuite
### What changes were proposed in this pull request?
Add the following code in `HashedRelationSuite`, to cover the API `HashedRelation#close` in the test suite.
```scala
protected override def afterEach(): Unit = {
super.afterEach()
assert(umm.executionMemoryUsed === 0)
}
```
### Why are the changes needed?
Doing this will:
1. Ensure `HashedRelation#close` is called in test code, to lower memory footprint and avoid memory leak when executing tests.
2. Ensure implementations of `HashedRelation#close` free the allocated memory blocks correctly.
It's an individual effort to improve the test quality, but also a prerequisite task for apache#52817.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
It's a test PR.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closesapache#52830 from zhztheplayer/wip-54132.
Authored-by: Hongze Zhang <hongze.zzz123@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the following code in
HashedRelationSuite, to cover the APIHashedRelation#closein the test suite.Why are the changes needed?
Doing this will:
HashedRelation#closeis called in test code, to lower memory footprint and avoid memory leak when executing tests.HashedRelation#closefree the allocated memory blocks correctly.It's an individual effort to improve the test quality, but also a prerequisite task for #52817.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
It's a test PR.
Was this patch authored or co-authored using generative AI tooling?
No.