Uh oh!
There was an error while loading. Please reload this page.
[SPARK-54138][SQL] Enforce constant configuration parameter for Theta and HLL - #52836
Closed
cboumalh wants to merge 2 commits into
Closed
[SPARK-54138][SQL] Enforce constant configuration parameter for Theta and HLL#52836cboumalh wants to merge 2 commits into
cboumalh wants to merge 2 commits into
Conversation
…nd Theta Sketches Aggregation
cboumalh
commented
Nov 2, 2025
ContributorAuthor
cc @dtenedor |
dtenedor
approved these changes
Nov 3, 2025
dtenedor
commented
Nov 3, 2025
Contributor
Looks good, thanks for the fix! |
dtenedor
commented
Nov 3, 2025
Contributor
Merging to master and 4.1 |
dtenedor pushed a commit
that referenced
this pull request
Nov 3, 2025
… and HLL ### What changes were proposed in this pull request? This PR enforces that the sketch configuration parameter (lgConfigK/lgNomEntries) in both HllSketchAgg and ThetaSketchAgg must be a constant value. If the parameter expression (right) is not foldable, a QueryExecutionErrors.*MustBeConstantError(prettyName) is thrown. This change ensures that the aggregation configuration is validated at analysis time rather than runtime, preventing inconsistent or invalid sketch behavior. ### Why are the changes needed? The configuration parameter determines the accuracy and memory footprint of the sketch. Allowing it to vary dynamically at runtime could lead to nondeterministic aggregation results and incorrect computations. By enforcing it as a constant expression, we ensure deterministic behavior, predictable memory use, and alignment with the expected semantics of sketch-based aggregations. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added tests in SQLQueryTestSuite ### Was this patch authored or co-authored using generative AI tooling? No Closes#52836 from cboumalh/hll-theta-check-foldable-param. Authored-by: Chris Boumalhab <cboumalh@amazon.com> Signed-off-by: Daniel Tenedorio <daniel.tenedorio@databricks.com> (cherry picked from commit be6ab9c) Signed-off-by: Daniel Tenedorio <daniel.tenedorio@databricks.com>
huangxiaopingRD pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
… and HLL ### What changes were proposed in this pull request? This PR enforces that the sketch configuration parameter (lgConfigK/lgNomEntries) in both HllSketchAgg and ThetaSketchAgg must be a constant value. If the parameter expression (right) is not foldable, a QueryExecutionErrors.*MustBeConstantError(prettyName) is thrown. This change ensures that the aggregation configuration is validated at analysis time rather than runtime, preventing inconsistent or invalid sketch behavior. ### Why are the changes needed? The configuration parameter determines the accuracy and memory footprint of the sketch. Allowing it to vary dynamically at runtime could lead to nondeterministic aggregation results and incorrect computations. By enforcing it as a constant expression, we ensure deterministic behavior, predictable memory use, and alignment with the expected semantics of sketch-based aggregations. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added tests in SQLQueryTestSuite ### Was this patch authored or co-authored using generative AI tooling? No Closesapache#52836 from cboumalh/hll-theta-check-foldable-param. Authored-by: Chris Boumalhab <cboumalh@amazon.com> Signed-off-by: Daniel Tenedorio <daniel.tenedorio@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enforces that the sketch configuration parameter (lgConfigK/lgNomEntries) in both HllSketchAgg and ThetaSketchAgg must be a constant value.
If the parameter expression (right) is not foldable, a QueryExecutionErrors.*MustBeConstantError(prettyName) is thrown.
This change ensures that the aggregation configuration is validated at analysis time rather than runtime, preventing inconsistent or invalid sketch behavior.
Why are the changes needed?
The configuration parameter determines the accuracy and memory footprint of the sketch.
Allowing it to vary dynamically at runtime could lead to nondeterministic aggregation results and incorrect computations.
By enforcing it as a constant expression, we ensure deterministic behavior, predictable memory use, and alignment with the expected semantics of sketch-based aggregations.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added tests in SQLQueryTestSuite
Was this patch authored or co-authored using generative AI tooling?
No