Skip to content

[SPARK-54436][SQL] Fix error formatting for incompatible table metadata checks - #53115

Closed
aokolnychyi wants to merge 1 commit into
apache:masterfrom
aokolnychyi:spark-53924-54157-followup
Closed

[SPARK-54436][SQL] Fix error formatting for incompatible table metadata checks#53115
aokolnychyi wants to merge 1 commit into
apache:masterfrom
aokolnychyi:spark-53924-54157-followup

Conversation

@aokolnychyi

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR fixes error formatting for recently added incompatible table metadata checks.

Why are the changes needed?

These changes are needed to avoid unnecessary empty lines.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

Was this patch authored or co-authored using generative AI tooling?

No.

@aokolnychyi

Copy link
Copy Markdown
ContributorAuthor

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, please use a different JIRA ID when ASF Infra is back, @aokolnychyi .

[SPARK-53924][SPARK-54157][SQL][FOLLOWUP] Fix error formatting for incompatible table metadata checks

@aokolnychyi

Copy link
Copy Markdown
ContributorAuthor

Sounds good, @dongjoon-hyun. When do you recommend using FOLLOWUP tags?

@viiryaviirya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting fix looks good.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Sounds good, @dongjoon-hyun. When do you recommend using FOLLOWUP tags?

Specifically, I don't recommend to use [FOLLOWUP] for multiple JIRA IDs, @aokolnychyi , because initially two original JIRA issues have independent theme already. When you aims to do a cross-theme style fix like this, it should be an independent JIRA issue.

@aokolnychyi

Copy link
Copy Markdown
ContributorAuthor

Makes sense. Thanks for explaining, @dongjoon-hyun!

@aokolnychyiaokolnychyi changed the title [SPARK-53924][SPARK-54157][SQL][FOLLOWUP] Fix error formatting for incompatible table metadata checks[SPARK-54436][SQL] Fix error formatting for incompatible table metadata checksNov 20, 2025
@aokolnychyi

Copy link
Copy Markdown
ContributorAuthor

@dongjoon-hyun, created a new JIRA issue and updated the title. Let me know if anything else is needed.

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @aokolnychyi and all

dongjoon-hyun pushed a commit that referenced this pull request Nov 20, 2025
…ta checks
### What changes were proposed in this pull request?
This PR fixes error formatting for recently added incompatible table metadata checks.
### Why are the changes needed?
These changes are needed to avoid unnecessary empty lines.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes#53115 from aokolnychyi/spark-53924-54157-followup.
Authored-by: Anton Okolnychyi <aokolnychyi@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 8cab074)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun

Copy link
Copy Markdown
Member

Merged to master/4.1 for Apache Spark 4.1.0.

@aokolnychyi

Copy link
Copy Markdown
ContributorAuthor

huangxiaopingRD pushed a commit to huangxiaopingRD/spark that referenced this pull request Nov 25, 2025
…ta checks
### What changes were proposed in this pull request?
This PR fixes error formatting for recently added incompatible table metadata checks.
### Why are the changes needed?
These changes are needed to avoid unnecessary empty lines.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closesapache#53115 from aokolnychyi/spark-53924-54157-followup.
Authored-by: Anton Okolnychyi <aokolnychyi@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@aokolnychyi@dongjoon-hyun@viirya@gengliangwang@cloud-fan@HyukjinKwon