Uh oh!
There was an error while loading. Please reload this page.
[SPARK-54464][SQL] Remove duplicate output.reserve calls in assembleVariantBatch - #53170
Closed
Zouxxyy wants to merge 1 commit into
Closed
[SPARK-54464][SQL] Remove duplicate output.reserve calls in assembleVariantBatch#53170Zouxxyy wants to merge 1 commit into
output.reserve calls in assembleVariantBatch#53170Zouxxyy wants to merge 1 commit into
Conversation
output.reserve calls in assembleVariantBatchdongjoon-hyun
previously requested changes
Nov 23, 2025
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
Thank you for suggestion, but it would be great if you can create a JIRA issue, @Zouxxyy .
Apache Spark comment prefers to use JIRA ID for trace-ability for source code change PR.
output.reserve calls in assembleVariantBatchoutput.reserve calls in assembleVariantBatchZouxxyy
commented
Nov 23, 2025
ContributorAuthor
Thanks, updated |
dongjoon-hyun
commented
Nov 23, 2025
Member
Thank you. |
| val converterVectors = Array(output) | ||
| val converterRow = new GenericInternalRow(1) | ||
| output.reset() | ||
| output.reserve(input.getElementsAppended) |
There was a problem hiding this comment.
According to the removed code, this comes from Apache Spark 4.0.0. cc @chenhao-db , @cloud-fan , @HyukjinKwon
dongjoon-hyun
approved these changes
Nov 23, 2025
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM.
Merged to master for Apache Spark 4.2.0.
cloud-fan
commented
Nov 24, 2025
Contributor
late LGTM |
huangxiaopingRD pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…leVariantBatch` ### What changes were proposed in this pull request? Remove duplicate output.reserve calls in assembleVariantBatch ### Why are the changes needed? output.reserve is called twice ### Does this PR introduce _any_ user-facing change? None. ### How was this patch tested? Existing test cases. ### Was this patch authored or co-authored using generative AI tooling? No Closesapache#53170 from Zouxxyy/master-20251120. Authored-by: zouxxyy <zouxinyu.zxy@alibaba-inc.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove duplicate output.reserve calls in assembleVariantBatch
Why are the changes needed?
output.reserve is called twice
Does this PR introduce any user-facing change?
None.
How was this patch tested?
Existing test cases.
Was this patch authored or co-authored using generative AI tooling?
No