Uh oh!
There was an error while loading. Please reload this page.
[SPARK-53991][SQL][TEST][FOLLOWUP] Make KLL quantile golden file tests deterministic - #53549
Closed
dtenedor wants to merge 1 commit into
Closed
[SPARK-53991][SQL][TEST][FOLLOWUP] Make KLL quantile golden file tests deterministic#53549dtenedor wants to merge 1 commit into
dtenedor wants to merge 1 commit into
Conversation
dtenedor
commented
Dec 19, 2025
ContributorAuthor
cc @cloud-fan here is a simple test fix. |
cloud-fan
approved these changes
Dec 22, 2025
cloud-fan
commented
Dec 22, 2025
Contributor
the OOM failure is unrelated, thanks, merging to master/4.1! |
cloud-fan pushed a commit
that referenced
this pull request
Dec 22, 2025
…s deterministic ### What changes were proposed in this pull request? In #52800, we added SQL support for KLL quantiles functions based on DataSketches. In this PR, we update some of the golden file tests to make them deterministic. ### Why are the changes needed? The previous tests generated string summaries of KLL quantile sketches and then split them by newlines and made case-sensitive checks for substrings. It turns out this was brittle, so this PR updates the tests to avoid the newline-splitting and makes the substring checks case-insenstiive. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This PR updates test coverage only. ### Was this patch authored or co-authored using generative AI tooling? No Closes#53549 from dtenedor/kll-quantile-golden-files-fix. Authored-by: Daniel Tenedorio <daniel.tenedorio@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit e4b9993) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #52800, we added SQL support for KLL quantiles functions based on DataSketches.
In this PR, we update some of the golden file tests to make them deterministic.
Why are the changes needed?
The previous tests generated string summaries of KLL quantile sketches and then split them by newlines and made case-sensitive checks for substrings. It turns out this was brittle, so this PR updates the tests to avoid the newline-splitting and makes the substring checks case-insenstiive.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This PR updates test coverage only.
Was this patch authored or co-authored using generative AI tooling?
No