Uh oh!
There was an error while loading. Please reload this page.
[SPARK-53991][SQL][TEST][FOLLOW-UP] Improve KLL quantile errors by removing internal details - #53702
Closed
dtenedor wants to merge 10 commits into
Closed
[SPARK-53991][SQL][TEST][FOLLOW-UP] Improve KLL quantile errors by removing internal details#53702dtenedor wants to merge 10 commits into
dtenedor wants to merge 10 commits into
Conversation
JIRA Issue Information=== Sub-task SPARK-53991 === This comment was automatically generated by GitHub Actions |
dtenedor
commented
Jan 6, 2026
ContributorAuthor
cboumalh
reviewed
Jan 6, 2026
| @@ -4293,7 +4293,7 @@ | |||
| }, | |||
| "KLL_SKETCH_INVALID_INPUT" : { | |||
Contributor
There was a problem hiding this comment.
We may want to consider updating this to: KLL_INVALID_INPUT_SKETCH_BUFFER to stay consistent with the errors for Theta and HLL since we also updated the function name below
cboumalh
commented
Jan 6, 2026
Contributor
Just one comment above, else LGTM. Thank you! |
dtenedor
requested review from
cboumalh and cloud-fan
and removed request for
cboumalhJanuary 6, 2026 23:18
cboumalh
approved these changes
Jan 6, 2026
cloud-fan
approved these changes
Jan 7, 2026
cloud-fan
commented
Jan 7, 2026
Contributor
The |
dtenedor
commented
Jan 7, 2026
ContributorAuthor
Thanks, it was! I pushed a fix, let's run the CI again. |
dtenedor
commented
Jan 7, 2026
ContributorAuthor
OK, all CI is passing now. Merging to master and 4.1. |
dtenedor added a commit
that referenced
this pull request
Jan 7, 2026
…moving internal details ### What changes were proposed in this pull request? This PR improves error messages from the new KLL quantile sketch functions added in #52800. ### Why are the changes needed? The previous error messages reported internal DataSketches library state which was not meaningful for end users of the SQL/DF functions in Apache Spark. ### Does this PR introduce _any_ user-facing change? Yes, error messages are improved. For example, before this change, we observed the following: ``` SELECT kll_sketch_get_rank_bigint(agg, 5) AS wrong_type FROM ( SELECT kll_sketch_agg_float(col1) AS agg FROM t_float_1_5_through_7_11 ) > For function `kll_sketch_get_rank_bigint`, invalid KLL sketch binary data: reqOffset: 40, reqLength: 56, (reqOff + reqLen): 96, allocSize: 60" ``` Now the error message becomes: ``` > "Invalid call to `kll_sketch_get_rank_bigint`; only valid KLL sketch buffers are supported as inputs (such as those produced by the `kll_sketch_agg` function)." ``` ### How was this patch tested? This PR updates golden file test coverage to show the improved error messages. ### Was this patch authored or co-authored using generative AI tooling? No. Closes#53702 from dtenedor/kll-quantiles-golden-files. Authored-by: Daniel Tenedorio <daniel.tenedorio@databricks.com> Signed-off-by: Daniel Tenedorio <daniel.tenedorio@databricks.com> (cherry picked from commit 9aea212) Signed-off-by: Daniel Tenedorio <daniel.tenedorio@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves error messages from the new KLL quantile sketch functions added in #52800.
Why are the changes needed?
The previous error messages reported internal DataSketches library state which was not meaningful for end users of the SQL/DF functions in Apache Spark.
Does this PR introduce any user-facing change?
Yes, error messages are improved. For example, before this change, we observed the following:
Now the error message becomes:
How was this patch tested?
This PR updates golden file test coverage to show the improved error messages.
Was this patch authored or co-authored using generative AI tooling?
No.