Uh oh!
There was an error while loading. Please reload this page.
[SPARK-6343] Doc driver-worker network reqs - #5382
Conversation
AmplabJenkins
commented
Apr 7, 2015
Can one of the admins verify this patch? |
srowen
commented
Apr 7, 2015
parente
commented
Apr 7, 2015
The original diagram source is in the https://github.com/apache/spark/blob/master/docs/img/cluster-overview.pptx Would you like me to remove it as part of the PR? |
srowen
commented
Apr 7, 2015
Oh I looked past that since it looked like a new file in Github. Yes leave it. |
JoshRosen
commented
Apr 8, 2015
LGTM; this is a nice improvement over the old diagram. |
pwendell
commented
Apr 9, 2015
Great to have an improvement here. One thing I don't understand, there are two curved arrows from the SparkContext to the Executors/Workers. However, in the upper arrow it is connected to the boundary of the Worker box and not the boundary of the Executor box. Is this intentional? I believe in theory, the process running the SparkContext should not need to directly communicate with the Worker nodes. It should only directly communicate with the Executor process. So maybe they should both touch the boundary of the Executor box. |
WangTaoTheTonic
commented
Apr 9, 2015
I have same question as Patrick too. |
Update cluster overview diagram to show connections from workers to driver. Add a bullet below about how driver listens / accepts connections from workers.
parente
commented
Apr 9, 2015
@pwendell@WangTaoTheTonic Good catch. I misconnected the upper line. It was not intentional. I've updated the PR with the diagram fix. |
pwendell
commented
Apr 9, 2015
Great LGTM - @WangTaoTheTonic does that look okay to you? |
WangTaoTheTonic
commented
Apr 9, 2015
LGTM +1 |
Attempt at making the driver-worker networking requirement more explicit and up-front in the documentation (see https://issues.apache.org/jira/browse/SPARK-6343). Update cluster overview diagram to show connections from workers to driver. Add a bullet below about how driver listens / accepts connections from workers. Author: Peter Parente <pparent@us.ibm.com> Closes#5382 from parente/SPARK-6343 and squashes the following commits: 0b2fb9d [Peter Parente] [SPARK-6343] Doc driver-worker network reqs (cherry picked from commit b9c51c0) Signed-off-by: Sean Owen <sowen@cloudera.com>
Attempt at making the driver-worker networking requirement more explicit and up-front in the documentation (see https://issues.apache.org/jira/browse/SPARK-6343).
Update cluster overview diagram to show connections from workers to driver. Add a bullet below about how driver listens / accepts connections from workers.