Uh oh!
There was an error while loading. Please reload this page.
[SPARK-55115][INFRA] Use master branch's base Dockerfile for release builds - #53890
Closed
cloud-fan wants to merge 1 commit into
Closed
[SPARK-55115][INFRA] Use master branch's base Dockerfile for release builds#53890cloud-fan wants to merge 1 commit into
cloud-fan wants to merge 1 commit into
Conversation
JIRA Issue Information=== Improvement SPARK-55115 === This comment was automatically generated by GitHub Actions |
cloud-fan
marked this pull request as draft
January 21, 2026 18:34
| # Old branch Dockerfiles may have broken dependencies (expired GPG keys, outdated base images, etc.) | ||
| run: | | ||
| git fetch origin master --depth=1 | ||
| git checkout origin/master -- dev/create-release/spark-rm/ |
Member
There was a problem hiding this comment.
Hm, I think we shoudn't? the dependencies might make the build fail. e.g., python requires some upper/lower bound depdencnies
ContributorAuthor
There was a problem hiding this comment.
I'll update it to only use the base docker file later.
cloud-fanforce-pushed
the
use-master-dockerfile-for-release
branch
from
January 23, 2026 09:46
1c4b6d2 to
bbb79f8Comparecloud-fan
marked this pull request as ready for review
January 23, 2026 09:47
HyukjinKwon
approved these changes
Jan 23, 2026
cloud-fan
commented
Jan 23, 2026
ContributorAuthor
release infra change, no need to wait for CI. Thanks for the review, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modified the release GitHub Actions workflow to always use master branch's
Dockerfile.basewhen building the release Docker image, instead of using theDockerfile.basefrom the release branch.Why are the changes needed?
Old branch Dockerfiles can become unmaintainable over time due to:
The master branch's
Dockerfile.baseis actively maintained and uses modern base images (Ubuntu 22.04), making release builds more reliable. Only the base Dockerfile is pulled from master, while the mainDockerfileremains from the release branch to preserve any release-specific configurations.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested locally for all the active branches with all the release steps (except for uploading)
Was this patch authored or co-authored using generative AI tooling?
Yes. cursor 2.3.41