Skip to content

[SPARK-6855] [SPARKR] Set R includes to get the right collate order. - #5462

Closed
shivaram wants to merge 1 commit into
apache:masterfrom
shivaram:collate-order
Closed

[SPARK-6855] [SPARKR] Set R includes to get the right collate order.#5462
shivaram wants to merge 1 commit into
apache:masterfrom
shivaram:collate-order

Conversation

@shivaram

Copy link
Copy Markdown
Contributor

This prevents tools like devtools::document creating invalid collate orders

This prevents tools like devtools::document creating invalid
collate orders
@shivaram

Copy link
Copy Markdown
ContributorAuthor

cc @cafreeman@davies

@cafreeman

Copy link
Copy Markdown

You may want to pull in the schema changes from earlier today since SQLtypes.R was replaced with schema.R

@SparkQA

Copy link
Copy Markdown

Test build #30058 has finished for PR 5462 at commit f3db562.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@shivaram

Copy link
Copy Markdown
ContributorAuthor

@cafreeman We will pull that change in #5436 and @davies will take care of merging it correctly.

@davies

Copy link
Copy Markdown
Contributor

LGTM.

@shivaram Could you merge this today? then I can rebase #5436

@SparkQA

Copy link
Copy Markdown

Test build #684 has finished for PR 5462 at commit f3db562.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@shivaram

Copy link
Copy Markdown
ContributorAuthor

Thanks @davies - I don't think the error has anything to do with this PR, but let me retest it anyways to be safe

Jenkins, retest this please

@SparkQA

Copy link
Copy Markdown

Test build #686 has finished for PR 5462 at commit f3db562.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shivaram@cafreeman@SparkQA@davies