Skip to content

[SPARK-7036][MLLIB] ALS.train should support DataFrames in PySpark - #5619

Closed
mengxr wants to merge 1 commit into
apache:masterfrom
mengxr:SPARK-7036
Closed

[SPARK-7036][MLLIB] ALS.train should support DataFrames in PySpark#5619
mengxr wants to merge 1 commit into
apache:masterfrom
mengxr:SPARK-7036

Conversation

@mengxr

Copy link
Copy Markdown
Contributor

SchemaRDD works with ALS.train in 1.2, so we should continue support DataFrames for compatibility. @coderxiang

@SparkQA

Copy link
Copy Markdown

Test build #30691 has finished for PR 5619 at commit dfcaf5a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@mengxr

Copy link
Copy Markdown
ContributorAuthor

test this please

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor issue: maybe better to use "%s is provided"

@coderxiang

Copy link
Copy Markdown
Contributor

LGTM.

@SparkQA

Copy link
Copy Markdown

Test build #30697 has finished for PR 5619 at commit dfcaf5a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

asfgit pushed a commit that referenced this pull request Apr 21, 2015
SchemaRDD works with ALS.train in 1.2, so we should continue support DataFrames for compatibility. coderxiang
Author: Xiangrui Meng <meng@databricks.com>
Closes#5619 from mengxr/SPARK-7036 and squashes the following commits:
dfcaf5a [Xiangrui Meng] ALS.train should support DataFrames in PySpark
(cherry picked from commit 686dd74)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr

Copy link
Copy Markdown
ContributorAuthor

Merged into master and branch-1.3.

markhamstra pushed a commit to markhamstra/spark that referenced this pull request Apr 23, 2015
SchemaRDD works with ALS.train in 1.2, so we should continue support DataFrames for compatibility. coderxiang
Author: Xiangrui Meng <meng@databricks.com>
Closesapache#5619 from mengxr/SPARK-7036 and squashes the following commits:
dfcaf5a [Xiangrui Meng] ALS.train should support DataFrames in PySpark
(cherry picked from commit 686dd74)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
SchemaRDD works with ALS.train in 1.2, so we should continue support DataFrames for compatibility. coderxiang
Author: Xiangrui Meng <meng@databricks.com>
Closesapache#5619 from mengxr/SPARK-7036 and squashes the following commits:
dfcaf5a [Xiangrui Meng] ALS.train should support DataFrames in PySpark
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mengxr@SparkQA@coderxiang