Uh oh!
There was an error while loading. Please reload this page.
Handle the vals that never used - #565
Conversation
AmplabJenkins
commented
Apr 26, 2014
Can one of the admins verify this patch? |
srowen
commented
Apr 26, 2014
I think this is a good change. It's pretty easy to run inspections over whole modules or the whole project to catch dead stores. I wonder if that's better than reviewing piecemeal changes? |
WangTaoTheTonic
commented
Apr 26, 2014
Hi Owen, thanks for your suggestion. |
srowen
commented
Apr 26, 2014
Just my $0.02 here -- I think the "teenager" variables, while not used, are there as illustrative examples and should likely be left in. The "host" variable likewise might useful just for completeness. I agree with the other changes you found. |
WangTaoTheTonic
commented
Apr 26, 2014
Thanks for that, i already fixed it. |
There was a problem hiding this comment.
Why does this get deleted? This is an example for expository purposes
WangTaoTheTonic
commented
Apr 27, 2014
You two guys differ about this, so what are we gonna do? |
rxin
commented
Apr 28, 2014
I don't think it is a big deal in this case. It could go either way so we probably shouldn't spend time arguing about this. |
rxin
commented
Apr 28, 2014
Jenkins, test this please. |
AmplabJenkins
commented
Apr 28, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 28, 2014
Merged build started. |
AmplabJenkins
commented
Apr 28, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 28, 2014
All automated tests passed. |
rxin
commented
Apr 30, 2014
Thanks. I've merged this. |
In XORShiftRandom.scala, use val "million" instead of constant "1e6.toInt". Delete vals that never used in other files. Author: WangTao <barneystinson@aliyun.com> Closes#565 from WangTaoTheTonic/master and squashes the following commits: 17cacfc [WangTao] Handle the unused assignment, method parameters and symbol inspected by Intellij IDEA 37b4090 [WangTao] Handle the vals that never used (cherry picked from commit 7025dda) Signed-off-by: Reynold Xin <rxin@apache.org>
…e#565. SPARK-1066: Add developer scripts to repository. These are some developer scripts I've been maintaining in a separate public repo. This patch adds them to the Spark repository so they can evolve here and are clearly accessible to all committers. I may do some small additional clean-up in this PR, but wanted to put them here in case others want to review. There are a few types of scripts here: 1. A tool to merge pull requests. 2. A script for packaging releases. 3. A script for auditing release candidates. Author: Patrick Wendell <pwendell@gmail.com> == Merge branch commits == commit 5d5d331d01f6fd59c2eb830f652955119b012173 Author: Patrick Wendell <pwendell@gmail.com> Date: Sat Feb 8 22:11:47 2014 -0800 SPARK-1066: Add developer scripts to repository.
In XORShiftRandom.scala, use val "million" instead of constant "1e6.toInt". Delete vals that never used in other files. Author: WangTao <barneystinson@aliyun.com> Closesapache#565 from WangTaoTheTonic/master and squashes the following commits: 17cacfc [WangTao] Handle the unused assignment, method parameters and symbol inspected by Intellij IDEA 37b4090 [WangTao] Handle the vals that never used
This reverts commit 4da04fc,
…e#591) * Revert "Revert "[SPARK-37600][BUILD] Upgrade to Hadoop 3.3.2" (apache#565)" This reverts commit 197dc34. * Revert "minor fix ut" This reverts commit 6ef82b4.
This reverts commit 4da04fc,
…e#591) * Revert "Revert "[SPARK-37600][BUILD] Upgrade to Hadoop 3.3.2" (apache#565)" This reverts commit 197dc34. * Revert "minor fix ut" This reverts commit 6ef82b4.
In XORShiftRandom.scala, use val "million" instead of constant "1e6.toInt".
Delete vals that never used in other files.