Uh oh!
There was an error while loading. Please reload this page.
[SPARK-57393][BUILD][FOLLOWUP] Clean out old PySpark sdists - #56996
Closed
nchammas wants to merge 3 commits into
Closed
[SPARK-57393][BUILD][FOLLOWUP] Clean out old PySpark sdists#56996nchammas wants to merge 3 commits into
nchammas wants to merge 3 commits into
Conversation
nchammas
commented
Jul 3, 2026
ContributorAuthor
cc @huaxingao since you authored the linked PR. Btw I didn't include the phrase |
uros-b
reviewed
Jul 5, 2026
Uh oh!
There was an error while loading. Please reload this page.
dongjoon-hyun
approved these changes
Jul 10, 2026
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM.
BTW, @nchammas , it changed the PR title for you according to the Apache Spark community convention. It would be greatly helpful if you follow the convention.
- [SPARK-57393] Build: Clean out old PySpark sdists
+ [SPARK-57393][BUILD][FOLLOWUP] Clean out old PySpark sdists
nchammas
commented
Jul 11, 2026
ContributorAuthor
I wrote "Build:" to mirror #56453, but yes thank you for the correction. This is indeed a follow-up PR. I will update the contributing guide to note the convention regarding follow-up PRs. It is currently not documented, even though it is an old convention. |
uros-b
commented
Jul 22, 2026
Member
Thank you @nchammas and @dongjoon-hyun! |
uros-b pushed a commit
that referenced
this pull request
Jul 22, 2026
### What changes were proposed in this pull request? Clear stale PySpark sdist tarballs from `python/dist/` before building new ones in `dev/make-distribution.sh`. ### Why are the changes needed? #56453 added a post-build validation that checks every `dist/pyspark*.tar.gz` for top-level LICENSE and NOTICE files. However, if `python/dist/` already contains tarballs from a previous build, the glob picks them up and the validation fails with: ``` ERROR: dist/pyspark-4.0.0.dev0.tar.gz is missing LICENSE at the package root ``` The script already cleans `pyspark.egg-info` to avoid stale caches. This change also cleans out old sdists. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I reproduced the failure locally with a stale `pyspark-4.0.0.dev0.tar.gz` in `python/dist/`, applied the fix, and confirmed `make-distribution.sh --pip` completes successfully. ### Was this patch authored or co-authored using generative AI tooling? Co-authored with GitHub Copilot. Closes#56996 from nchammas/SPARK-57393-clean-old-sdists. Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit b0e28f8) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
uros-b
commented
Jul 22, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clear stale PySpark sdist tarballs from
python/dist/before building new ones indev/make-distribution.sh.Why are the changes needed?
#56453 added a post-build validation that checks every
dist/pyspark*.tar.gzfor top-level LICENSE and NOTICE files. However, ifpython/dist/already contains tarballs from a previous build, the glob picks them up and the validation fails with:The script already cleans
pyspark.egg-infoto avoid stale caches. This change also cleans out old sdists.Does this PR introduce any user-facing change?
No.
How was this patch tested?
I reproduced the failure locally with a stale
pyspark-4.0.0.dev0.tar.gzinpython/dist/, applied the fix, and confirmedmake-distribution.sh --pipcompletes successfully.Was this patch authored or co-authored using generative AI tooling?
Co-authored with GitHub Copilot.